625914 - Firefox Beta 9 claims addon is not compatible when it is during upgrade

Status: VERIFIED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Mike Kaply [:mkaply]]

We have two version of our addon, one for AMO, one not AMO.

When you install our non AMO version which has an install.rdf that says 3.6 - 4.9.* onto beta 8, and then upgrade to beta 9, beta 9 says it's not compatible. Checking for compatibility doesn't work. You have to reinstall.

If you try the same thing with our AMO version, it works fine.

The addon installs fine on beta 9.

The addon is Personas Interactive 1.0.6

http://pages.brandthunder.com/btpersonas/download

I've tested multiple times and verified my results.

Comment 1

[Mike Kaply [:mkaply]]

Argh. It says 4.0.* - that was a typo.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, I have seen the same thing lately for our Mozmill extension, which is also part of the CLI interface and not exclusively hosted on AMO. Is our version comparator code broken?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Doesn't look like. The following code returns true:

window.alert(Components.classes["@mozilla.org/xpcom/version-comparator;1"].getService(Components.interfaces.nsIVersionComparator).compare("4.0.*", "4.0b9") >= 0);

So it's probably in the compatibility update code.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

One problem I was made aware of recently is the following: if a user has installed version X and it's compatible with Firefox up to 4.0.*, but the metadata on AMO for version X says it's only compatible with 3.6.*, the add-on will be considered as incompatible in Firefox 4. This is intentional so the developer can remove compatibility in case of a serious problem detected after release.

Can you confirm that the version you're testing has the right compatibility info on AMO?

Comment 5

[Mike Kaply [:mkaply]]

Yes, the version I'm testing has the right compatibility on AMO. AMO says 4.0.*

https://addons.mozilla.org/en-US/firefox/addon/personas-interactive-252557/

Comment 6

[Mike Kaply [:mkaply]]

Our update.rdf is wrong. If I disconnect from the Internet and do the upgrade, it works.

Sorry for the false alarm.

Although, on another note, Our UI for checking add-ons when you aren't connected to the internet is bad.

Someone should test that.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #6)
> Our update.rdf is wrong. If I disconnect from the Internet and do the upgrade,
> it works.

Good to hear. Thanks Michael.

> Although, on another note, Our UI for checking add-ons when you aren't
> connected to the internet is bad.

Can you please file a bug with exact steps to reproduce? I'm not aware that we have a bug for the update case.