Closed Bug 626180 Opened 14 years ago Closed 14 years ago

Name of plugin in List view and Detail view and about:plugins is wrong if the name contains non-ASCII character.

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 final+)

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b10
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: alice0775, Assigned: jfkthame)

References

Details

(Keywords: regression, Whiteboard: [softblocker])

Attachments

(2 files)

Screenshot
287.69 KB, image/png
Details
Screenshot about:plugins
100.40 KB, image/png
Details
Attached image Screenshot — 
Build Identifier:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110115 Firefox/4.0b10pre ID:20110115030345

Name of plugin in List view and Detail view is wrong if the name contains non-ASCII character.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield with New profile and a certain plugin
2. Ctrl+Shift+A and Choose Plugins pane

Actual Results:
 The name is corrupted.

Expected Results:
 The name should be shown properly.


Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/fd860ead3077
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110111 Firefox/4.0b10pre ID:20110111030825
Fails:
http://hg.mozilla.org/mozilla-central/rev/3f8bee2e48a7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110111 Firefox/4.0b10pre ID:20110111032048
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fd860ead3077&tochange=3f8bee2e48a7
blocking2.0: --- → ?
This also happens in about:plugins
Component: Add-ons Manager → Plug-ins
Product: Toolkit → Core
QA Contact: add-ons.manager → plugins
Summary: Name of plugin in List view and Detail view is wrong if the name contains non-ASCII character. → Name of plugin in List view and Detail view and about:plugins is wrong if the name contains non-ASCII character.
Target Milestone: --- → mozilla2.0
Yes, this is a regression from the patch in bug 607121, which was incorrect; see my comments there. Fix coming shortly.
Description also
Do we have a chance for an automated test?
Flags: in-testsuite?
Target Milestone: mozilla2.0 → ---
(In reply to comment #4)
> Do we have a chance for an automated test?

Yes; I was working on this for bug 607121, and it's now posted there for review.
Assignee: nobody → jfkthame
blocking2.0: ? → final+
Whiteboard: [softblocker]
Pushed partial-backout and testcase additions in bug 607121:
  http://hg.mozilla.org/mozilla-central/rev/d0323a335993
  http://hg.mozilla.org/mozilla-central/rev/f48d19c20a7d
This should now be fixed as a result.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Alice, could you please check if this is fixed for you? Thanks.
Flags: in-testsuite? → in-testsuite+
Target Milestone: --- → mozilla2.0b10
(In reply to comment #7)
> Alice, could you please check if this is fixed for you? Thanks.

Confirmed,
this was fixed on latest m-c Minefield .
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre ID:20110119030331
Thanks.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: