"Make description private" checkbox should set bz_private class on the comment box

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
User Interface
--
enhancement
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: reed, Assigned: dkl)

Tracking

3.6.3
Bugzilla 4.0
Bug Flags:
approval +
approval4.0 +

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

8 years ago
+++ This bug was initially created as a clone of Bug #626266 +++

The "Make description private" checkbox needs to set the 'bz_private' class on the comment box when it's checked.
(Assignee)

Comment 1

8 years ago
Created attachment 504793 [details] [diff] [review]
Patch to add bz_private class to description/comment field (v1)

Patch to add bz_private class to description when clicking comment privacy checkbox in enter_bug.cgi. Also fixes issue in show_bug.cgi when replying to a private comment where bz_private was not being added to the comment field there.

Please review
Dave
Assignee: ui → dkl
Status: NEW → ASSIGNED
Attachment #504793 - Flags: review?(mkanat)

Comment 2

7 years ago
Comment on attachment 504793 [details] [diff] [review]
Patch to add bz_private class to description/comment field (v1)

I'm pretty sure that "document.changeform" is an old, deprecated syntax.

Perhaps we should make updateCommentTagControl accept strings as well as objects. There are some YUI methods that will let you do this, like YUI.util.Dom.get, I believe.
Attachment #504793 - Flags: review?(mkanat) → review-

Updated

7 years ago
Target Milestone: --- → Bugzilla 4.0
(Assignee)

Comment 3

7 years ago
Created attachment 505691 [details] [diff] [review]
Patch to add bz_private class to description/comment field (v2)

New patch addressing Max's suggested changes.

Dave
Attachment #504793 - Attachment is obsolete: true
Attachment #505691 - Flags: review?(mkanat)
(Assignee)

Comment 4

7 years ago
Created attachment 505698 [details] [diff] [review]
Patch to add bz_private class to description/comment field (v3)

New patch that simply takes a string for the field to add the bz_private class to as the second argument to updateCommentTagControl().

Dave
Attachment #505691 - Attachment is obsolete: true
Attachment #505698 - Flags: review?(mkanat)
Attachment #505691 - Flags: review?(mkanat)
(Assignee)

Comment 5

7 years ago
Created attachment 505702 [details] [diff] [review]
Patch to add bz_private class to description/comment field (v4)

Simplified to use YAHOO.util.Dom.addClass(field, 'bz_private') instead of using YAHOO.util.Dom.get(field).

Dave
Attachment #505698 - Attachment is obsolete: true
Attachment #505702 - Flags: review?(mkanat)
Attachment #505698 - Flags: review?(mkanat)

Updated

7 years ago
Attachment #505702 - Flags: review?(mkanat) → review+

Updated

7 years ago
Flags: approval4.0+
Flags: approval+
(Assignee)

Comment 6

7 years ago
trunk:
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/ modified js/field.js
modified template/en/default/bug/edit.html.tmpl
modified template/en/default/bug/create/create.html.tmpl
Committed revision 7658.

4.0:
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/4.0/ modified js/field.js
modified template/en/default/bug/edit.html.tmpl
modified template/en/default/bug/create/create.html.tmpl
Committed revision 7516.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.