626416 - Fix buildbotcustom unittests

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

buildbotcustom unittests output (using nosetests):

........................EF..................................
======================================================================
ERROR: test_lastChangeset
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builds/buildbot/preproduction/sandbox/lib/python2.5/site-packages/Twisted-10.1.0-py2.5-linux-i686.egg/twisted/internet/defer.py", line 125, in maybeDeferred
    result = f(*args, **kw)
  File "/builds/buildbot/preproduction/sandbox/lib/python2.5/site-packages/Twisted-10.1.0-py2.5-linux-i686.egg/twisted/internet/utils.py", line 191, in runWithWarningsSuppressed
    result = f(*a, **kw)
  File "/builds/buildbot/preproduction/slave/test-masters/buildbotcustom/test/test_misc_scheduler_nightly.py", line 76, in test_lastChangeset
    c = lastChangeset(self.dbc, 'b1')
TypeError: lastChangeset() takes exactly 3 arguments (2 given)

======================================================================
FAIL: test_lastGoodFunc
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builds/buildbot/preproduction/sandbox/lib/python2.5/site-packages/Twisted-10.1.0-py2.5-linux-i686.egg/twisted/internet/defer.py", line 125, in maybeDeferred
    result = f(*args, **kw)
  File "/builds/buildbot/preproduction/sandbox/lib/python2.5/site-packages/Twisted-10.1.0-py2.5-linux-i686.egg/twisted/internet/utils.py", line 191, in runWithWarningsSuppressed
    result = f(*a, **kw)
  File "/builds/buildbot/preproduction/slave/test-masters/buildbotcustom/test/test_misc_scheduler_nightly.py", line 136, in test_lastGoodFunc
    self.assertEquals(ss.revision, 'r1')
  File "/builds/buildbot/preproduction/sandbox/lib/python2.5/site-packages/Twisted-10.1.0-py2.5-linux-i686.egg/twisted/trial/unittest.py", line 287, in failUnlessEqual
    % (msg, pformat(first), pformat(second)))
FailTest: not equal:
a = None
b = 'r1'


----------------------------------------------------------------------
Ran 60 tests in 19.686s

FAILED (errors=1, failures=1)

Comment 1

[Chris AtLee [:catlee]]

I think you touched this code last...

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

The first is easy to fix; the second (and a few others) are caused by

changeset:   1110:3fb5af3ae220
user:        Chris AtLee <[e-mail]>
date:        Wed Dec 01 12:17:33 2010 -0500
summary:     Bug 615878: Ignore changes without revlinks or with DONTBUILD in the comments for the purposes of determining the latest revision to use for nightlies. r=bhearsum,rail

wherein the test changes don't have a revlink.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m626416-buildbotcustom-r1.patch

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 506482 [details] [diff] [review]
m626416-buildbotcustom-r1.patch

Woo!  Thanks for finding this!

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 506482 [details] [diff] [review]
m626416-buildbotcustom-r1.patch

04f8954b0309

This will get merged to production as a ridealong, since it's just test changes.