626471 - Make initial filters (passed in parameters) working again

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Mounir Lamouri (:mounir)]

Because there is a popupevent sent at the page load, they are overridden.

Comment 1

[Justin Lebar (not reading bugmail)]

Having not looked at this code at all, why not:

* Always use a state object when calling pushstate.
* On popstate, if the state object is null, ignore the popstate / look at the parameters passed in however they're passed.

Although you might be tempted to call replaceState before the page loads and set a state object, that won't work until bug 615501 lands.

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to comment #1)
> Having not looked at this code at all, why not:
> 
> * Always use a state object when calling pushstate.

We do.

> * On popstate, if the state object is null, ignore the popstate / look at the
> parameters passed in however they're passed.

I tried but it didn't work. I should re-examine that.

> Although you might be tempted to call replaceState before the page loads and
> set a state object, that won't work until bug 615501 lands.

Let's try to find a solution that actually works now ;)

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

So the method suggested by Justin is working. I must have done something stupid when I tried earlier.

Comment 4

[Mounir Lamouri (:mounir)]

Pushed:
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/9a192458c2bb