626487 - Admin review text is not displayed in Editor review pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Steps to reproduce:
1) Go to an add-on review page.
2) Choose to Request Super-Review and add some text.

Expected result:
The add-on get the Admin Review flag and the text appears in the add-on review history.

Observed result:
The Admin Review flag is set but the text doesn't appear.

Comment 1

[Wil Clouser [:clouserw]]

Are you sure this is a regression?  This is all still php.

To do this it looks like we might need to mess with something close to line 353 of controllers/components/editors.php

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

We're positive. Admin comments have been used pretty heavily.

Comment 3

[Barry Chen]

Attachment: fixes the super review request comment regression

One of the fields for Approval was missing.  This was on initial add-on reviews, but not update reviews.

Comment 4

[Wil Clouser [:clouserw]]

Comment on attachment 504632 [details] [diff] [review]
fixes the super review request comment regression

Please commit! thanks.  Jorge, can you verify this works once it lands?

Comment 5

[Barry Chen]

Committed @ r81174

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #4)
> Please commit! thanks.  Jorge, can you verify this works once it lands?

Will do.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

It's working on allizom. I'll verify once it's live.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.allizom.org/en-US/editors/review/53213?num=1

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...