Steps to reproduce: 1) Go to an add-on review page. 2) Choose to Request Super-Review and add some text. Expected result: The add-on get the Admin Review flag and the text appears in the add-on review history. Observed result: The Admin Review flag is set but the text doesn't appear.
Are you sure this is a regression? This is all still php. To do this it looks like we might need to mess with something close to line 353 of controllers/components/editors.php
Assignee: nobody → chenba
We're positive. Admin comments have been used pretty heavily.
Created attachment 504632 [details] [diff] [review] fixes the super review request comment regression One of the fields for Approval was missing. This was on initial add-on reviews, but not update reviews.
Attachment #504632 - Flags: review?(clouserw)
Comment on attachment 504632 [details] [diff] [review] fixes the super review request comment regression Please commit! thanks. Jorge, can you verify this works once it lands?
Attachment #504632 - Flags: review?(clouserw) → review+
Committed @ r81174
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(In reply to comment #4) > Please commit! thanks. Jorge, can you verify this works once it lands? Will do.
It's working on allizom. I'll verify once it's live.
Verified FIXED on https://addons.allizom.org/en-US/editors/review/53213?num=1
Status: RESOLVED → VERIFIED
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.