Admin review text is not displayed in Editor review pages

VERIFIED FIXED in 5.12.7

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
P2
normal
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: jorgev, Assigned: Barry Chen)

Tracking

({regression})

unspecified
5.12.7
regression

Details

(Whiteboard: [ReviewTeam], URL)

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Steps to reproduce:
1) Go to an add-on review page.
2) Choose to Request Super-Review and add some text.

Expected result:
The add-on get the Admin Review flag and the text appears in the add-on review history.

Observed result:
The Admin Review flag is set but the text doesn't appear.
Are you sure this is a regression?  This is all still php.

To do this it looks like we might need to mess with something close to line 353 of controllers/components/editors.php
Assignee: nobody → chenba
(Reporter)

Comment 2

7 years ago
We're positive. Admin comments have been used pretty heavily.
(Assignee)

Comment 3

7 years ago
Created attachment 504632 [details] [diff] [review]
fixes the super review request comment regression

One of the fields for Approval was missing.  This was on initial add-on reviews, but not update reviews.
Attachment #504632 - Flags: review?(clouserw)
Comment on attachment 504632 [details] [diff] [review]
fixes the super review request comment regression

Please commit! thanks.  Jorge, can you verify this works once it lands?
Attachment #504632 - Flags: review?(clouserw) → review+
(Assignee)

Comment 5

7 years ago
Committed @ r81174
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

7 years ago
(In reply to comment #4)
> Please commit! thanks.  Jorge, can you verify this works once it lands?

Will do.
(Reporter)

Comment 7

7 years ago
It's working on allizom. I'll verify once it's live.
(Assignee)

Updated

7 years ago
Duplicate of this bug: 628271
Created attachment 506883 [details]
Post-fix screenshot
Verified FIXED on https://addons.allizom.org/en-US/editors/review/53213?num=1
Status: RESOLVED → VERIFIED
(Reporter)

Comment 11

6 years ago
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.