626497 - XBL bindings to resource: URLs should not trigger a validation warning.

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Kris Maglione [:kmag]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b10pre) Gecko/20110116 Firefox/4.0b10pre
Build Identifier: 

Currently -moz-binding properties in CSS files trigger a warning when they point to any non-chrome: URL. While arguably they should be valid for any non-remote URL, they should certainly not be flagged for resource: URLs, especially as these become more and more common with the introduction of bootstrapped add-ons which are not allowed to register chrome packages.

Reproducible: Always

Comment 1

[Wil Clouser [:clouserw]]

Jorge:  what do you want to do here?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

We should allow: chrome URLs, relative chrome URLs (no protocol), and resource URLs. That should cover the majority of cases.

Comment 3

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> We should allow: chrome URLs, relative chrome URLs (no protocol), and resource
> URLs. That should cover the majority of cases.

Allow meaning no warnings or no errors?

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #3)
> (In reply to comment #2)
> > We should allow: chrome URLs, relative chrome URLs (no protocol), and resource
> > URLs. That should cover the majority of cases.
> 
> Allow meaning no warnings or no errors?

Yes, sorry for the ambiguity.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Double fail...

In the 3 cases mentioned in Comment 2 there should be no warnings or errors at all. In all other cases there should be a warning.

Comment 6

[Matt Basta [:basta]]

Fixed:

https://github.com/mattbasta/amo-validator/commit/4d67fa6dc8b8cb8ebdadb317350961854412c572

Comment 8

[Mike Kaply [:mkaply]]

When does this promote?

Comment 9

[Kumar McMillan [:kumar]]

Pushed to zamboni in https://github.com/jbalogh/zamboni-lib/commit/25381ac884d082dbfadca7531e56e3132cf5e198