Closed Bug 626584 Opened 15 years ago Closed 7 years ago

All feature names should be #undef'd after feature processing

Categories

(Tamarin Graveyard :: Tools, defect)

Product:
Tamarin Graveyard
Component:
Tools
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Future

People

(Reporter: lhansen, Unassigned)

Details

The AVMSYSTEM_, AVMFEATURE_, and AVMTWEAK_ names are visible to avmshell and Flash Player source, but they shouldn't be - only the names defined as a consequence of the feature settings should be visible. The feature processor should therefore emit #undefs at the end of avmfeatures.h probably. Before we can land that change we need to ensure that no code is relying on those names, and if it is, it must be rewritten. (For example, the generated file avmfeatures.cpp depends on those names.)
Flags: flashplayer-qrb+
Target Milestone: --- → Future
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.