626587 - XPI file is uploaded with localized name / cannot download uploaded XPI file if the addon has a localized name

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[YUKI "Piro" Hiroshi]

Attachment: screenshot: uploaded file with localized name

When I uploaded an XPI file for a new version of my addon, it is unexpectedly uploaded with the localized name. Moreover, when I clicked the link to the XPI file, it said "404 File Not Found".

This problem appears with following conditions:

 * I access to AMO's localized page
   (e.g. https://addons.mozilla.org/ja/developers/addons )
 * The addon has localized name. For example, the addon "Informational Tab"
   ( https://addons.mozilla.org/ja/firefox/addon/informational-tab/ ) has two
   names:
     "Informational Tab" for en-US
     "情報化タブ (Informational Tab)" for ja

Then, the uploaded file is renamed to "情報化タブ_informational_tab-XXXX-fx.xpi", and there is a download link to https://addons.mozilla.org/_files/4930/%E6%83%85%E5%A0%B1%E5%8C%96%E3%82%BF%E3%83%96_informational_tab-XXXX-fx.xpi but it is 404.

Comment 1

[YUKI "Piro" Hiroshi]

Attachment: screenshot: the link

Comment 2

[Jeff Balogh (:jbalogh)]

Uploading in en-US should work around this for now.

Comment 3

[Jeff Balogh (:jbalogh)]

This appears to be an issue somewhere between Apache and the file system, so unicode file names are on the way out. The file exists with the name we expect but it can't be accessed through Apache. Even if we debugged this on our servers, we'd have to deal with the same issues on the release mirrors.

Comment 4

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/4c72d9b

Comment 5

[Wil Clouser [:clouserw]]

The conclusion was to stop allowing UTF-8 in file names since we can't guarantee the configuration of our release mirrors.  Add-on names and slugs are still allowed UTF-8.

thanks jeff

Comment 6

[krupa raj[:krupa]]

Filed bug 628787 about the vague error message.

Add-ons with unicode in their file name fail upload.

Checked that unicode is still allowed in add-on names and slugs @ https://addons.allizom.org/en-US/firefox/addon/%E3%82%A2%E3%83%89%E3%82%AA%E3%83%B3%E3%82%92%E3%83%96%E3%83%A9%E3%82%A6%E3%82%BA/

Comment 7

[krupa raj[:krupa]]

Attachment: post-fix screenshot