Closed Bug 626683 Opened 11 years ago Closed 11 years ago

tabitems.js:905 - TypeError: this._reconnect is not a function

Categories

(Firefox Graveyard :: Panorama, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 4.0b10

People

(Reporter: ttaubert, Assigned: ttaubert)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Introduced with bug 609685.
Attached patch v1 (obsolete) — Splinter Review
Integration typo fixed.
Attachment #504757 - Flags: review?(ian)
Attachment #504757 - Flags: feedback?(ian)
Attachment #504757 - Flags: review?(ian)
Attachment #504757 - Flags: review+
Attachment #504757 - Flags: feedback?(ian)
Severity: normal → blocker
Keywords: checkin-needed
Priority: -- → P1
I'm going to consider this breakage and land it shortly
This simple fix failed rather spectacularly when I tried to land it:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295375280.1295376474.13367.gz

Looks like it needs some debugging.
Keywords: checkin-needed
In fact, that reconnect call, introduced in the patch for bug 609685, shouldn't be necessary at all anymore… do you know what it's for, or is it just left over from before I cleaned up the reconnect code?
(In reply to comment #4)
> In fact, that reconnect call, introduced in the patch for bug 609685, shouldn't
> be necessary at all anymore… do you know what it's for, or is it just left over
> from before I cleaned up the reconnect code?

Yeah, looks like the fix is we just need to remove the reconnect. Sorry I didn't catch that before.
Attached patch patch v2Splinter Review
Assignee: seanedunn → tim.taubert
Attachment #504757 - Attachment is obsolete: true
Attachment #505258 - Flags: review?(ian)
Pushed to try.
Comment on attachment 505258 [details] [diff] [review]
patch v2

Yup!
Attachment #505258 - Flags: review?(ian) → review+
Attachment #505258 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/d4d318dc283e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.