Closed Bug 626683 Opened 11 years ago Closed 11 years ago
.js:905 - Type Error: this ._reconnect is not a function
Introduced with bug 609685.
Integration typo fixed.
Severity: normal → blocker
Priority: -- → P1
I'm going to consider this breakage and land it shortly
This simple fix failed rather spectacularly when I tried to land it: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295375280.1295376474.13367.gz Looks like it needs some debugging.
In fact, that reconnect call, introduced in the patch for bug 609685, shouldn't be necessary at all anymore… do you know what it's for, or is it just left over from before I cleaned up the reconnect code?
(In reply to comment #4) > In fact, that reconnect call, introduced in the patch for bug 609685, shouldn't > be necessary at all anymore… do you know what it's for, or is it just left over > from before I cleaned up the reconnect code? Yeah, looks like the fix is we just need to remove the reconnect. Sorry I didn't catch that before.
Pushed to try.
Comment on attachment 505258 [details] [diff] [review] patch v2 Yup!
Attachment #505258 - Flags: review?(ian) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.