626683 - tabitems.js:905 - TypeError: this._reconnect is not a function

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P1)

Description

[Tim Taubert [:ttaubert] (inactive)]

Introduced with bug 609685.

Comment 1

[Sean Dunn]

Attachment: v1

Integration typo fixed.

Comment 2

[Ian Gilman [:iangilman]]

I'm going to consider this breakage and land it shortly

Comment 3

[Ian Gilman [:iangilman]]

This simple fix failed rather spectacularly when I tried to land it:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295375280.1295376474.13367.gz

Looks like it needs some debugging.

Comment 4

[Ian Gilman [:iangilman]]

In fact, that reconnect call, introduced in the patch for bug 609685, shouldn't be necessary at all anymore… do you know what it's for, or is it just left over from before I cleaned up the reconnect code?

Comment 5

[Ian Gilman [:iangilman]]

(In reply to comment #4)
> In fact, that reconnect call, introduced in the patch for bug 609685, shouldn't
> be necessary at all anymore… do you know what it's for, or is it just left over
> from before I cleaned up the reconnect code?

Yeah, looks like the fix is we just need to remove the reconnect. Sorry I didn't catch that before.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Pushed to try.

Comment 8

[Ian Gilman [:iangilman]]

Comment on attachment 505258 [details] [diff] [review]
patch v2

Yup!

Comment 9

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/d4d318dc283e