626719 - When downloading an add-on with unsaved edits, we must save before creating/sending the XPI

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Daniel Buchner [:dbuc]]

Currently, if you edit code files on an add-on in the Builder and then try to download the add-on without manually hitting save first, the add-on XPI is created with out-of-date code.

Comment 1

[Piotr Zalewa [:zalun]]

Or disable Download button if edited. 

Also we need an additional button which would reset current changes. I will try to switch the edited back on - just after the ACE integration

Comment 2

[Daniel Buchner [:dbuc]]

Uhh, no I think clicking download should just fire a save event if the flag for unsaved is present. If you want to wait for ACE so that you don't have to do rework that is fine, but disabling like that is terrible UX...

Comment 3

[Piotr Zalewa [:zalun]]

We agreed to have a modal displayed if code was changed. User will have 3 options.
[Save&Download] [Download without saving] [Cancel]

Comment 6

[Wil Clouser [:clouserw]]

Why would a user ever want to download without saving?

Comment 7

[Piotr Zalewa [:zalun]]

No idea - but I think it's bad to autosave, so maybe no [download without saving] button

Comment 8

[Daniel Buchner [:dbuc]]

I can see a use-case where a user loses track of what they are doing mid-edit and tries to download a file that will inevitably break, though to Wil's point, I don't think this will be a common case.

Let's go ahead and give them the three choices: [Save & Download] [Download without saving] [Cancel]

Comment 9

[Piotr Zalewa [:zalun]]

https://github.com/zalun/FlightDeck/commit/2708d0d8c56455d4d0371c52143cbac316ae97fd

Fixed - the only thing to check is the text.
For "default" style in the default button another bug will be filed

Comment 10

[Wil Clouser [:clouserw]]

In the future please like to commits on mozilla/flightdeck and put the bug number in the commit messages.  thanks

Comment 11

[Ayan Shah[:ashah]]

follow up bug filed - https://bugzilla.mozilla.org/show_bug.cgi?id=644326