626732 - nsNullPrincipal::CheckMayLoad uses nsScriptSecurityManager in a thread-unsafe way (since it uses string bundles)

Status: RESOLVED INVALID

(Core :: Security: CAPS, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

nsNullPrincipal::CheckMayLoad uses nsScriptSecurityManager in a thread-unsafe way (since it uses string bundles).

I guess we want nsNullPrincipal to be threadsafe, so we need to fix this somehow.

Comment 1

[Boris Zbarsky [:bzbarsky]]

> I guess we want nsNullPrincipal to be threadsafe

We do?  Why?  What operations on it do we want to be threadsafe?

In general, principals and the security manager are not threadsafe last I checked....

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

See bug 626301, shaver wants us to use nsNullPrincipal for Workers.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Resolving invalid because I think things are now worse than they were in comment 0 and this should be superseded by more up-to-date bugs; CheckMayLoad is generally main-thread-only at this time and for reasons not just involving string bundles (which can be side-stepped).