Closed
Bug 626741
Opened 13 years ago
Closed 13 years ago
At Mozilla Careers site with NoScript forcing HTTPS for www.mozilla.com: "###!!! ASSERTION: attempt to modify an immutable nsStandardURL: 'Error', file nsStandardURL.cpp, line 1164"
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b10
People
(Reporter: dholbert, Assigned: dholbert)
References
()
Details
(Keywords: assertion)
Attachments
(1 file)
1.09 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE: 0. Be running a debug mozilla-central build. 1. Install NoScript ( http://noscript.net/getit ) & restart Firefox 2. In the NoScript options "Advanced" tab, "HTTPS" subtab, add www.mozilla.com to the top text box, under "Force the following sites to use secure (HTTPS) connections" 3. Load http://hire.jobvite.com/CompanyJobs/Jobs.aspx?c=qpX9Vfwa ACTUAL RESULTS: 2 instances of ###!!! ASSERTION: attempt to modify an immutable nsStandardURL: 'Error', file ../../../../mozilla/netwerk/base/src/nsStandardURL.cpp, line 1164 The failure is in a call to nsStandardURL::SetScheme, with |input| = "https", and with this->mSpec = "http://www.mozilla.com/img/tignish/template/mozilla-logo.png" I'm not sure if this is a NoScript bug or a Firefox bug... FWIW, it doesn't happen if I use the "STS UI" addon (instead of NoScript) to force HTTPS on www.mozilla.com.
Comment 1•13 years ago
|
||
I think this assert is bogus, unless we expect all consumers to check for mutability before mutating. If noscript doesn't check for failure to SetScheme, of course, that's a bug in noscript.
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to comment #1) > I think this assert is bogus, unless we expect all consumers to check for > mutability before mutating. Ok -- perhaps it should be NS_WARN_IF_FALSE instead of NS_ASSERTION then? > If noscript doesn't check for failure to SetScheme, of course, that's a bug in > noscript. (At the moment, I've got no reason to suspect that NoScript is missing any failure-checks. I filed this bug on the assertion-failure, which happens inside of SetScheme, just before it fails.)
Keywords: assertion
Comment 3•13 years ago
|
||
In fact, NoScript does check for failure and takes the potentially more expensive internal redirection route whenever it cannot modify the URL in place.
Comment 4•13 years ago
|
||
WARN_IF_FALSE sounds good to me.
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to comment #2) > Ok -- perhaps it should be NS_WARN_IF_FALSE instead of NS_ASSERTION then? Or rather, NS_WARNING instead of NS_ERROR. This patch does that.
Assignee | ||
Updated•13 years ago
|
Component: General → Networking
QA Contact: general → networking
Comment 6•13 years ago
|
||
Comment on attachment 504851 [details] [diff] [review] fix: s/NS_ERROR/NS_WARNING/ r=me
Attachment #504851 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/ad17b38cdc8d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
You need to log in
before you can comment on or make changes to this bug.
Description
•