XMLObject::_toXMLString removes namespaces incorrectly

RESOLVED FIXED

Status

Tamarin
Virtual Machine
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

(Whiteboard: WE:2787930)

Attachments

(1 attachment)

941 bytes, patch
Rick Reitmaier
: review+
Werner Sharp
: feedback+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
quoth Werner:

this loop in XMLObject::_toXMLString is backwards:

  while (namespaceLength > newNamespaceArray.length())
     newNamespaceArray.removeLast();

it should be:

     while (newNamespaceArray.length() > namespaceLength)
         newNamespaceArray.removeLast();

prior to the NamespaceList change it was:

     newNamespaceArray->setLength (namespaceLength);
(Assignee)

Updated

7 years ago
Whiteboard: WE:2787930
(Assignee)

Comment 1

7 years ago
Created attachment 504831 [details] [diff] [review]
Patch
Assignee: nobody → stejohns
Attachment #504831 - Flags: review?(rreitmai)
Attachment #504831 - Flags: feedback?(wsharp)

Updated

7 years ago
Attachment #504831 - Flags: feedback?(wsharp) → feedback+

Comment 2

7 years ago
Comment on attachment 504831 [details] [diff] [review]
Patch

r+ seems correct.
Attachment #504831 - Flags: review?(rreitmai) → review+
(Assignee)

Comment 3

7 years ago
TR 5805:a191bb3a8ed3
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.