Closed Bug 626777 Opened 15 years ago Closed 14 years ago

killableprocess should really kill the process finally

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: k0scist, Unassigned)

Details

If the process handler still exists when we're finally really ready to kill it (e.g. in runner.cleanup), then we should try to kill it with a SIGKILL. This may help with edge cases like bug 615662
On closer inspection, we are in fact sending SIGKILL: https://github.com/mozautomation/mozmill/blob/master/mozprocess/mozprocess/killableprocess.py#L173 It is just the spurious argument to the runner's stop method that threw me off (bug 627064). Closing as invalid, though the bare except clause in killableprocess is somewhat worrisome: https://github.com/mozautomation/mozmill/blob/master/mozprocess/mozprocess/killableprocess.py#L188
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.