626887 - [traceback] RuntimeError: Spidermonkey version too old; 1.8pre+ required

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Wil Clouser [:clouserw]]

Looks like this error is coming up consistently from 2 add-ons.  Not sure if the error is correct or not, but would like some insight on it.  Is there something flaky with our spidermonkey versions or is this pointing to something else?


   created: 2011-01-17 01:56:15
      name: searchbastard-amo1.5.4.xpi
      path: /mnt/netapp_amo/addons.mozilla.org-remora/files/temp/5bce7c3232484d40b6453a5ff039f4e4.xpi
task_error: Traceback (most recent call last):
  File "/data/amo_python/www/prod/zamboni/apps/devhub/tasks.py", line 27, in validator
    result = _validator(upload.path)
  File "/data/amo_python/www/prod/zamboni/apps/devhub/tasks.py", line 70, in _validator
    spidermonkey=settings.SPIDERMONKEY)
  File "/data/amo_python/www/prod/zamboni/vendor/src/amo-validator/validator/validate.py", line 37, in validate
    validator.submain.prepare_package(bundle, path, expectation)
  File "/data/amo_python/www/prod/zamboni/vendor/src/amo-validator/validator/submain.py", line 52, in prepare_package
    output = test_package(err, package, path, expectation)
  File "/data/amo_python/www/prod/zamboni/vendor/src/amo-validator/validator/submain.py", line 139, in test_package
    return test_inner_package(err, package_contents, package)
  File "/data/amo_python/www/prod/zamboni/vendor/src/amo-validator/validator/submain.py", line 202, in test_inner_package
    test_func(err, package_contents, package)
  File "/data/amo_python/www/prod/zamboni/vendor/src/amo-validator/validator/testcases/content.py", line 166, in test_packed_packages
    file_data)
  File "/data/amo_python/www/prod/zamboni/vendor/src/amo-validator/validator/testcases/scripting.py", line 27, in test_js_file
    errorbundle=err)
  File "/data/amo_python/www/prod/zamboni/vendor/src/amo-validator/validator/testcases/scripting.py", line 239, in _get_tree
    raise RuntimeError("Spidermonkey version too old; "
RuntimeError: Spidermonkey version too old; 1.8pre+ required


Will upload culprits in a minute

Comment 1

[Wil Clouser [:clouserw]]

Attachment: 626887.xpi

Comment 2

[Wil Clouser [:clouserw]]

Attachment: 626877-2.xpi

Comment 3

[Matt Basta [:basta]]

I can't reproduce this locally. Is the problem still occurring?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot; still happens on preview

Comment 5

[Matt Basta [:basta]]

What version/build of Spidermonkey is on preview? I'll install it locally and see if I can reproduce it that way.

Comment 6

[Wil Clouser [:clouserw]]

oremj, can you tell us?  If basta is using a newer version (I didn't know there was one?) maybe we should just upgrade.

Either way, can we catch this error in case the same things comes up in a future version?  We should be log.error()ing it

Comment 7

[Jeremy Orem [:oremj]]

How do I tell which version I am using?

Comment 8

[Wil Clouser [:clouserw]]

SPIDERMONKEY in the config is pointing to an executable.  Run that:

./js --version

On my copy (which I think is the same as yours?) I get:


JavaScript-C 1.8.0 pre-release 1 2007-10-03

Comment 9

[Jeremy Orem [:oremj]]

[root@pm-app-amo24 tracemonkey]# ./tracemonkey -h
JavaScript-C 1.8.0 pre-release 1 2007-10-03

Comment 10

[Matt Basta [:basta]]

I have the same version output. Could you try running the shell and posting the output to version()?

Comment 11

[Wil Clouser [:clouserw]]

clouserw@khan:~/temp/spidermonkey/js/src/Linux_DBG.OBJ$ ./js
js> version()
185
js>

Comment 12

[Kumar McMillan [:kumar]]

Checking the version doesn't help much because the final release in all the distros is in fact "1.8"

Here is how to test:

CORRECT:

$ js -e "Reflect"

INCORRECT:

$ js -e "Reflect"
-e:1: ReferenceError: Reflect is not defined


If there is no ReferenceError then the right version was installed.

Comment 13

[Wil Clouser [:clouserw]]

(In reply to comment #12)
> Checking the version doesn't help much because the final release in all the
> distros is in fact "1.8"

Awesome

> Here is how to test:
> 
> CORRECT:
> 
> $ js -e "Reflect"
> 
> INCORRECT:
> 
> $ js -e "Reflect"
> -e:1: ReferenceError: Reflect is not defined
> 
> 
> If there is no ReferenceError then the right version was installed.

My build works correctly.  oremj?

Comment 14

[Matt Basta [:basta]]

Well this is certainly stumping. I'm writing up some new unit tests this week. Hopefully they'll shed some light on what's going on.

Comment 15

[Wil Clouser [:clouserw]]

(In reply to comment #14)
> Well this is certainly stumping. I'm writing up some new unit tests this week.
> Hopefully they'll shed some light on what's going on.

Well, let's see what oremj is running

Comment 16

[Jeremy Orem [:oremj]]

[root@pm-app-amo25 tracemonkey]# ./tracemonkey -e "Reflect"
[root@pm-app-amo25 tracemonkey]#

Comment 17

[Jeremy Orem [:oremj]]

[root@pm-app-amo25 tracemonkey]# ./tracemonkey 
js> version()
185
js>

Comment 18

[Wil Clouser [:clouserw]]

So, we're all using the same thing. :)

Comment 19

[Kumar McMillan [:kumar]]

I wonder if this was a timing issue close to the first deploy.  I can't reproduce this on allizom, using the same xpi.  https://addons.allizom.org/z/en-US/developers/upload/eba43215a7ce4afdb1ea18238c451772

Comment 20

[Matt Basta [:basta]]

Can this be confirmed to be reproducible? I really don't know where to go from here.

Comment 21

[Wil Clouser [:clouserw]]

Kumar says no.  I'll keep an eye on the logs.