Closed Bug 626900 Opened 14 years ago Closed 12 years ago

Firefox hang in mozilla::plugins::PPluginInstanceParent::CallNPP_Destroy

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: marcia, Unassigned)

References

Details

(Keywords: hang)

Crash Data

Seen while reviewing crash stats. Currently the #16 crash on the trunk when looking at all data.

http://tinyurl.com/63256rf to the reports which are all Windows.

Frame 	Module 	Signature [Expand] 	Source
0 	ntdll.dll 	KiFastSystemCallRet 	
1 	ntdll.dll 	ZwWaitForSingleObject 	
2 	kernel32.dll 	WaitForSingleObjectEx 	
3 	kernel32.dll 	WaitForSingleObject 	
4 	xul.dll 	google_breakpad::ExceptionHandler::WriteMinidumpOnHandlerThread 	toolkit/crashreporter/google-breakpad/src/client/windows/handler/exception_handler.cc:754
5 	xul.dll 	google_breakpad::ExceptionHandler::WriteMinidumpForException 	toolkit/crashreporter/google-breakpad/src/client/windows/handler/exception_handler.cc:769
6 	xul.dll 	google_breakpad::ExceptionHandler::WriteMinidump 	toolkit/crashreporter/google-breakpad/src/client/windows/handler/exception_handler.cc:811
7 	xul.dll 	CrashReporter::CreatePairedMinidumps 	toolkit/crashreporter/nsExceptionHandler.cpp:2081
8 	xul.dll 	mozilla::plugins::PluginModuleParent::ShouldContinueFromReplyTimeout 	dom/plugins/PluginModuleParent.cpp:254
9 	xul.dll 	mozilla::ipc::SyncChannel::ShouldContinueFromTimeout 	ipc/glue/SyncChannel.cpp:261
10 	xul.dll 	mozilla::ipc::RPCChannel::Call 	ipc/glue/RPCChannel.cpp:210
11 	xul.dll 	mozilla::plugins::PPluginInstanceParent::CallNPP_Destroy 	obj-firefox/ipc/ipdl/PPluginInstanceParent.cpp:588
12 	xul.dll 	mozilla::plugins::PluginInstanceParent::Destroy 	dom/plugins/PluginInstanceParent.cpp:202
13 	xul.dll 	mozilla::plugins::PluginModuleParent::NPP_Destroy 	dom/plugins/PluginModuleParent.cpp:428
14 	xul.dll 	nsNPAPIPluginInstance::Stop 	modules/plugin/base/src/nsNPAPIPluginInstance.cpp:213
15 	xul.dll 	nsPluginHost::StopPluginInstance 	modules/plugin/base/src/nsPluginHost.cpp:3224
16 	xul.dll 	DoStopPlugin 	layout/generic/nsObjectFrame.cpp:2532
17 	xul.dll 	nsStopPluginRunnable::Run 	layout/generic/nsObjectFrame.cpp:2577
18 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:633
19 	nspr4.dll 	PR_AssertCurrentThreadOwnsLock 	nsprpub/pr/src/threads/combined/prulock.c:404
20 	nspr4.dll 	PR_AssertCurrentThreadOwnsLock 	nsprpub/pr/src/threads/combined/prulock.c:404
21 	xul.dll 	mozilla::ipc::MessagePump::Run 	ipc/glue/MessagePump.cpp:110
22 	xul.dll 	MessageLoop::RunInternal 	ipc/chromium/src/base/message_loop.cc:219
23 	xul.dll 	MessageLoop::RunHandler 	ipc/chromium/src/base/message_loop.cc:202
24 	xul.dll 	nsPropertiesParser::ParseBuffer 	xpcom/ds/nsPersistentProperties.cpp:455
Blocks: 645587
Crash Signature: [@ hang | mozilla::plugins::PPluginInstanceParent::CallNPP_Destroy(short*) ]
It seems to have arisen more since the last Flash update. Here’s my most recent one:

a5565383-705e-4894-9a8c-2ac852110623
It is #7 top hanger/crasher on 5.0 and #8 on 6.0b3.
It happens here too with Aurora. I can watch videos just fine, it's just when I finish or close the tab that the whole browser hangs for about 30 seconds or so.
Happening awhile
reference: 2b4b537f-a955-482f-abc2-d54c22111012
This seems to happen always in conjunction with one on the following crashes:

Maybe someone could put these together

Bug 687828 - Print through the Adobe Flash Plugin freezes Firefox on ikea.com

Bug 561019 - Plugin waveOutOpen hangs 

they all seem to have to do with this stupid plugin. sounds like a rethinking of this thing is in order
Keywords: topcrash
Keywords: crash, topcrash
I was able to reproduce this crash by opening a few tabs and then leaving the flash content playing overnight. When I came in this morning flash had crashed.

Crash report: https://crash-stats.mozilla.com/report/index/974cc7c5-f71a-482c-84c9-366752120724

Running a pre-release version of flash.

Open tabs:

1. http://vimeo.com/couchmode/industrialcolormotion/videos/sort:date/38117569 (Playing in Couch Mode)
2. http://www.cnn.com/video/#/video/living/2012/07/23/orig-music-alabama-shakes.cnn
3. http://www.youtube.com/watch?v=3E-1UMsb7wM&feature=g-logo-xit
(In reply to Marcia Knous [:marcia] from comment #11)

> Crash report:
> https://crash-stats.mozilla.com/report/index/974cc7c5-f71a-482c-84c9-
> 366752120724
> 
> Running a pre-release version of flash.

https://crash-stats.mozilla.com/report/index/2c63558d-90a4-4f60-83f5-4da472120724

Your crash is a Windows 8 Release Preview specific bug "Crash Report [@ hang | ntdll.dll@...]" and should be fixed with Flash Player >11.4.400.231 and/or Windows 8 RTM.
Adobe Bug 3285905 (prerelease) = closed - fixed (2012-07-20)
This bug is only applicable when the browser crash is not paired with a plugin crash.
Summary: Firefox 4.0b9 Crash Report [@ hang | mozilla::plugins::PPluginInstanceParent::CallNPP_Destroy(short*) ] → Firefox hang in mozilla::plugins::PPluginInstanceParent::CallNPP_Destroy
(In reply to Scoobidiver from comment #13)
> This bug is only applicable when the browser crash is not paired with a
> plugin crash.

an indicator that the sandbox process is no longer around?
What scoobidiver is saying (I think) is that this signature is a browser-side signature and isn't very useful by itself. The reasons that the Flash plugin may be hanging while we call NPP_Destroy are numerous and we really need to bucket by the Flash stack(s) if possible.
Ben, Please explain what you mean by this:
"and we really need to bucket by the Flash stack(s) if possible."
The signature here is a "bucket of crashes". But this bucket is almost meaningless, since it just indicates that the browser is calling into the plugin. The interesting grouping is what the plugin is doing.
I'm closing this as INCOMPLETE as those browser-side hang reports didn't get us anywhere and we are reworking hang reporting. Those signatures are not seen any more as browser sides of hang pairs are not recorded any more. We will have dumps/stacks of browser and other processes right in one report together with their plugin hang parts in the future (product-wise starting with FF18, we're still working on proper support on the server side, please contact bsmedberg if you want to help).
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.