Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [required amo-editors]
Target Milestone: --- → Q1 2011
I think the whole viewer should be rethought and was going to kick this out of Q1. However, if you have code for what you want here, I'll ask chenb to merge it in.
Assignee: nobody → maglione.k
Priority: -- → P5
Implementation as a HTML fragment suitable for insertion into diff viewer headers. Should ideally be merged into diff stylesheets and external JS files.
Attachment #505608 - Attachment mime type: text/html → text/plain
Thanks, over to chenba. Looks like there are some syntax errors at the end of <style> to clean up. Remora allows inline JS/CSS so if it comes down to it you're welcome to do that. Security bugs are higher priority than this.
Assignee: maglione.k → chenba
Attachment #505608 - Attachment is obsolete: true
It worked fine for me. Code's the same as kmag's attachment 506101 [details], but separated into two locations. @kmag thanks
Attachment #515001 - Flags: review?(clouserw)
Comment on attachment 515001 [details] [diff] [review] patch with code from kmag I hope this works with our new CDN and that .js file. We'll find out.
Attachment #515001 - Flags: review?(clouserw) → review+
Committed @ r83193
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Thanks barry. I see this on https://addons.allizom.org/en-US/firefox/files/diff/108581/ We can push this out next Thursday.
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.