627195 - JavaScript strict warning: assignment to undeclared variables in calendar-dialog-utils.js file

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Decathlon]

Attachment: patch

Steps to Reproduce:
1. set the preference "javascript.options.strict" to true via config. editor;
2. import the following ics calendar:

BEGIN:VCALENDAR
BEGIN:VEVENT
CREATED:20110119T221233Z
LAST-MODIFIED:20110119T221317Z
DTSTAMP:20110119T221317Z
UID:bd1c030e-e904-4975-8617-82c0905947da
SUMMARY:TEST
RRULE:FREQ=YEARLY;BYMONTHDAY=19;BYMONTH=1
DTSTART;TZID=Europe/Berlin:20110119T230000
DTEND;TZID=Europe/Berlin:20110120T000000
END:VEVENT
END:VCALENDAR


3. open the event TEST just imported with the calendar.


Actual Results:
in the console you can see the following messages

Warning: assignment to undeclared variable bymonth
Source File: chrome://calendar/content/calendar-dialog-utils.js
Line: 255

Warning: assignment to undeclared variable bymonthday
Source File: chrome://calendar/content/calendar-dialog-utils.js
Line: 256


The same issue occurs with the "byday" variable when the rule is something like this:
RRULE:FREQ=YEARLY;BYDAY=SU;BYMONTH=1

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 505201 [details] [diff] [review]
patch

r=philipp

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/1ee83630c951>
-> FIXED

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/ffaa09e58172>
a=philipp