Post-FF4: Enable browser.sessionhistory.optimize_eviction

RESOLVED FIXED in mozilla6

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: azakai, Unassigned)

Tracking

Trunk
mozilla6
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

9 years ago
Followup to bug 610417. We enabled the pref for Fennec, but left it off for Firefox to not risk regressions.

After FF4, we should enable this pref for Firefox, since it is beneficial (see details in previous bug, and TODO comments in the patch for that bug).

Updated

9 years ago
No longer blocks: FF2SM
From the patch in bug 610417:
// NB: After 4.0, we should remove this option and the corresponding
//     pref - optimization should always be used

So I guess now that Firefox 4 has been released, this optimization should be used and the browser.sessionhistory.optimize_eviction pref should be removed?
Reporter

Comment 2

8 years ago
Posted patch patch (obsolete) — Splinter Review
Thanks for the reminder mw22!
Attachment #525119 - Flags: review?(Olli.Pettay)
Comment on attachment 525119 [details] [diff] [review]
patch

Could we first flip the pref for desktop FF and after some time
remove this code.
Attachment #525119 - Flags: review?(Olli.Pettay)
Reporter

Comment 4

8 years ago
That does sound safer.

Btw, I don't know how these prefs update existing installations - will users that upgrade to this code get the pref changed? Or will it remain as it was set before (so they won't get the optimization)?
Attachment #525119 - Attachment is obsolete: true
Attachment #526775 - Flags: review?(Olli.Pettay)
Attachment #526775 - Flags: review?(Olli.Pettay) → review+
Reporter

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
(In reply to comment #4)
> Created attachment 526775 [details] [diff] [review]
> change pref to true
> 
> That does sound safer.
> 
> Btw, I don't know how these prefs update existing installations - will users
> that upgrade to this code get the pref changed? Or will it remain as it was set
> before (so they won't get the optimization)?

I just installed the latest hourly build and checked before installing that the pref was 'false' - after the install to latest hourly/Nightly - the pref is now 'true' , so users will get the optimization without issue.
Reporter

Comment 7

8 years ago
Thanks Jim, good to know.
You need to log in before you can comment on or make changes to this bug.