Closed
Bug 627215
Opened 12 years ago
Closed 12 years ago
Post-FF4: Enable browser.sessionhistory.optimize_eviction
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: azakai, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
2.01 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Followup to bug 610417. We enabled the pref for Fennec, but left it off for Firefox to not risk regressions. After FF4, we should enable this pref for Firefox, since it is beneficial (see details in previous bug, and TODO comments in the patch for that bug).
Comment 1•12 years ago
|
||
From the patch in bug 610417: // NB: After 4.0, we should remove this option and the corresponding // pref - optimization should always be used So I guess now that Firefox 4 has been released, this optimization should be used and the browser.sessionhistory.optimize_eviction pref should be removed?
Reporter | ||
Comment 2•12 years ago
|
||
Thanks for the reminder mw22!
Attachment #525119 -
Flags: review?(Olli.Pettay)
Comment 3•12 years ago
|
||
Comment on attachment 525119 [details] [diff] [review] patch Could we first flip the pref for desktop FF and after some time remove this code.
Attachment #525119 -
Flags: review?(Olli.Pettay)
Reporter | ||
Comment 4•12 years ago
|
||
That does sound safer. Btw, I don't know how these prefs update existing installations - will users that upgrade to this code get the pref changed? Or will it remain as it was set before (so they won't get the optimization)?
Attachment #525119 -
Attachment is obsolete: true
Attachment #526775 -
Flags: review?(Olli.Pettay)
Updated•12 years ago
|
Attachment #526775 -
Flags: review?(Olli.Pettay) → review+
Reporter | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/17cbe366cd51
Reporter | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → mozilla6
Comment 6•12 years ago
|
||
(In reply to comment #4) > Created attachment 526775 [details] [diff] [review] > change pref to true > > That does sound safer. > > Btw, I don't know how these prefs update existing installations - will users > that upgrade to this code get the pref changed? Or will it remain as it was set > before (so they won't get the optimization)? I just installed the latest hourly build and checked before installing that the pref was 'false' - after the install to latest hourly/Nightly - the pref is now 'true' , so users will get the optimization without issue.
Reporter | ||
Comment 7•12 years ago
|
||
Thanks Jim, good to know.
You need to log in
before you can comment on or make changes to this bug.
Description
•