627229 - Clicking "Name this tab group" textbox doesn't focus it

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Jesse Ruderman]

1. Go into tab view (Cmd+Shift+E)
2. Hover over the top of the tab group to make a textbox appear.
3. Click the part of the textbox that is after the emptytext.

Result: textbox is not focused

---------------------------------
| / Name this tab group...      |
---------------------------------
                             ^ 
                             | 
                             | clicking here does nothing

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Indeed, good point. I don't think this is a huge priority for fx4, though, so we'll punt. Adding ux, though, in case I'm wrong.

Comment 2

[Harry]

Attachment: Patch v1

A simple fix, I think. First proper patch, hope I'm doing this right. Apologies if I'm not.

Comment 3

[Ian Gilman [:iangilman]]

Comment on attachment 508285 [details] [diff] [review]
Patch v1

I think this solution is too aggressive; rather than making the entire title bar hot, we should just make sure the whole text box is hot.

Tim, second opinion?

Harry, thanks for diving in!

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 508285 [details] [diff] [review]
Patch v1

(In reply to comment #3)
> I think this solution is too aggressive; rather than making the entire title
> bar hot, we should just make sure the whole text box is hot.

Indeed, we should not use the whole title bar. There are even some bugs out there to correct the cursor when hovering it (and not the input itself) because many will use the free space to drag the group around.

Anyway, thanks Harry!

Comment 5

[Harry]

Ah, you would prefer the reverse approach of not highlighting the textbox when you rollover the title bar? Fair dos :) Are there any bugs/patches outstanding for that, or am I free to go after that instead? Thanks!

Comment 6

[Ian Gilman [:iangilman]]

(In reply to comment #5)
> Ah, you would prefer the reverse approach of not highlighting the textbox when
> you rollover the title bar? Fair dos :) Are there any bugs/patches outstanding
> for that, or am I free to go after that instead? Thanks!

No patches, but there are some related bugs. I think bug 619055 is what we're talking about. There's also bug 627228, which may be related or may be invalid. Bug 624936 may also be related.

Anyway, go for it! :)

Comment 7

[Raymond Lee [:raymondlee]]

This works for me with latest trunk.  
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.2a1pre) Gecko/20110407 Firefox/6.0a1

Can you still reproduce it?

Comment 8

[Jesse Ruderman]

WFM on trunk as well.