627266 - setting status of non-ffox* trees did not result in anything in TBPL

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

When I closed the various trees, I only saw the resulting statuses at the top of the page (after restart) on Firefox, Firefox3.5, Firefox3.6, and TraceMonkey.  Places and MozillaTry did not show anything.

It's hard to tell, but I suspect that pushes to try kept right on rolling.  Right now I see Try pushes within the time the tree was closed (see bug 627225) - 15:50, 15:55, 16:04, 16:25, 16:37, and 16:40.  I was slow to figure out I needed to close more than the three Firefox trees -- but I certainly had them closed more than 12 minutes before I reopened the tree (that is, the tree was definitely closed at 16:40).

Comment 1

[Phil Ringnalda (:philor)]

I would have thought the interesting part of that was "pushes to try kept right on rolling," an hg bug, but if this is a tbpl bug, I fixed it, by fixing tinderbox. What winds up on top of tbpl is the content of the thing with id="status-container" minus the content of a thing with id="preamble", so I gave try a container, and gave places a container and a preamble for its preamble.

Comment 2

[Chris Cooper [:coop] (he/him)]

(In reply to comment #1)
> I would have thought the interesting part of that was "pushes to try kept right
> on rolling," an hg bug,

Does that mean that we're missing the hg hook to prevent check-ins on try during tree closure, or the hook exists but because we were missing the proper stanza on tinderbox to check against, check-ins continued?

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

I suspect philor's diagnosis is the correct one (hook exists, but no stanza), as it matches what I saw.  Let's see what happens the next time those branches are closed?

Comment 4

[Phil Ringnalda (:philor)]

I wasn't actually diagnosing anything about the treeclosure hook, since it looks for a different thing (<span id="treestatus"...). Filed bug 630065 on the hook apparently not being installed.