627272 - Cannot start dragging titlebar when Firefox button opens its menu

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

1. Press Firefox button and open its menu
2. mousedown on titlebar of the window
3. drag the window

Actual result:
Cannot move the window

Expected result:
Can move the window

If the opened menu is context menu or menus on menu bar, I can move the window. The behavior is native behavior on Windows.

The cause is that XUL button menu consumes mousedown event on outside of the menu. I think that this is just a mistake. The attached patch passed all tests on tryserver.

Comment 1

[Paul [pwd]]

Confirmed. Might want to add to the whiteboard [has patch].

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 505305 [details] [diff] [review]
Patch v1.0

This provides platform native behavior for XUL menu button (only changed on Windows). I don't think that this patch affects other XUL elements, so, I think this isn't risky.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 505305 [details] [diff] [review]
Patch v1.0

I think this should land after Gecko 2.0 / Firefox 4.0 branches.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Please attach an import ready patch (with the author name and the commit message) before setting checkin-needed.

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/6ff7867b840f