Closed Bug 627291 Opened 9 years ago Closed 9 years ago

GfxInfo no longer needs ISupports impl.

Categories

(Core :: Widget: Android, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

build bustage:

/home/dougt/android-ndk-r4c/build/prebuilt/linux-x86/arm-eabi-4.4.0/bin/arm-eabi-g++ -o GfxInfo.o -c  -fvisibility=hidden -DXPCOM_TRANSLATE_NSGM_ENTRY_POINT=1 -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DOSTYPE=\"Linux\" -DOSARCH=Linux -D_IMPL_NS_WIDGET -DEXCLUDE_SKIA_DEPENDENCIES -DCHROMIUM_MOZILLA_BUILD  -DOS_LINUX=1 -DOS_POSIX=1  -I/builds/mozilla-central/widget/src/xpwidgets -I/builds/mozilla-central/widget/src/shared -I/builds/mozilla-central/dom/system/android -I/builds/mozilla-central/widget/src/android  -I/builds/mozilla-central/ipc/chromium/src -I/builds/mozilla-central/ipc/glue -I../../../ipc/ipdl/_ipdlheaders  -I/builds/mozilla-central/widget/src/android -I. -I../../../dist/include -I../../../dist/include/nsprpub  -I/home/dougt/builds/mozilla-central/obj-android/dist/include/nspr -I/home/dougt/builds/mozilla-central/obj-android/dist/include/nss       -fPIC -I/home/dougt/android-ndk-r4c/build/platforms/android-5/arch-arm/usr/include -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -Wno-long-long -mandroid -I/home/dougt/android-ndk-r4c/build/platforms/android-5/arch-arm/usr/include -msoft-float -fno-short-enums -fno-exceptions -fno-strict-aliasing -fshort-wchar -Wl,--no-wchar-size-warning -march=armv7-a -mthumb -Wa, -march=armv7-a -Wa, -mthumb -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -fomit-frame-pointer  -I/home/dougt/android-ndk-r4c/build/platforms/android-5/arch-arm/usr/include  -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MF .deps/GfxInfo.pp /builds/mozilla-central/widget/src/android/GfxInfo.cpp
/builds/mozilla-central/widget/src/android/GfxInfo.cpp:56: error: no 'nsrefcnt mozilla::widget::GfxInfo::AddRef()' member function declared in class 'mozilla::widget::GfxInfo'
/builds/mozilla-central/widget/src/android/GfxInfo.cpp:56: error: no 'nsrefcnt mozilla::widget::GfxInfo::Release()' member function declared in class 'mozilla::widget::GfxInfo'
/builds/mozilla-central/widget/src/android/GfxInfo.cpp:56: error: no 'nsresult mozilla::widget::GfxInfo::QueryInterface(const nsIID&, void**)' member function declared in class 'mozilla::widget::GfxInfo'
make[1]: *** [GfxInfo.o] Error 1



I think we no longer need the isupports impl.
Attached patch patch v.1Splinter Review
Attachment #505347 - Flags: review?(mwu)
Summary: GfxInfo no longer needs ISupports → GfxInfo no longer needs ISupports impl.
http://hg.mozilla.org/mozilla-central/rev/efbf1fa4c70e

Joe, can you verify that this is the best possible fix?
Attachment #505347 - Flags: review?(mwu)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Sorry guys. Yes, that's the right fix.
Assignee: nobody → doug.turner
You need to log in before you can comment on or make changes to this bug.