627292 - safebrowsing tests hit the network for mozilla.com/firefox/its-(an-attack|a-trap).html

Status: RESOLVED DUPLICATE of bug 663211

(Toolkit :: Safe Browsing, defect)

Description

[Phil Ringnalda (:philor)]

Accessing the network from tests is a sure path to intermittent orange. I'm sort of surprised that I've only actually seen these tests fail once, though they may not require much in the way of response from mozilla.com. In any case, we should do something else in http://mxr.mozilla.org/mozilla-central/source/browser/components/safebrowsing/content/test/browser_bug415846.js and http://mxr.mozilla.org/mozilla-central/source/browser/components/safebrowsing/content/test/browser_bug400731.js rather than hitting mozilla.com.

Probably the best thing to do would be to have tests that want to hit a blocked page insert their own URL the same way http://mxr.mozilla.org/mozilla-central/source/browser/components/safebrowsing/content/malware-warden.js#60 inserts the mozilla.com ones, only using a host from http://mxr.mozilla.org/mozilla-central/source/build/pgo/server-locations.txt that's already proxied. A less-pretty solution that would require less typing would be just to add mozilla.com to server-locations.txt.

Comment 1

[Phil Ringnalda (:philor)]

I'd feel better about having filed this invalid bug if not for the way that it wasn't until I was actually writing a patch for it that I realized I'd just been running browser-chrome tests with Wireshark running and hadn't seen a single bit of traffic to mozilla.com. Whatever it was that caused those failures, it wasn't that.

Comment 2

[Mehdi Mulani [:mmm] (I don't check this)]

Interestingly I found that I could not access any of the test pages in Work Offline mode.
This seems to be caused by the timing of the safe browsing query, though I don't know too much about it now.

Comment 3

[Phil Ringnalda (:philor)]

Apparently I was wrong about it being invalid. I would have missed browser_bug415846.js since it's disabled on OS X, dunno why I didn't see traffic for browser_bug400731.js.