Closed Bug 627306 Opened 9 years ago Closed 9 years ago
UMR with dispatch
310 bytes, text/html
973 bytes, text/plain
40.13 KB, text/plain
799 bytes, patch
|Details | Diff | Splinter Review|
With this testcase, Valgrind complains of uninitialized memory from nsIDOMEventTarget_DispatchEvent making its way into js::Interpret. And lo, if I print the return value from dispatchEvent, sometimes I get true and sometimes I get false, seemingly at random. http://hg.mozilla.org/mozilla-central/annotate/80c4d7317c29/content/events/src/nsEventListenerManager.cpp#l1316 returns NS_OK without setting _retval, so it's suspicious.
Looks like a regression from quickstubs...
Er, no, this is ancient.
What's the correct behavior? Set the retval to true, I guess? http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventTarget-dispatchEvent
Assignee: nobody → jruderman
Status: NEW → ASSIGNED
Attachment #505690 - Flags: review?(Olli.Pettay)
This patch makes the Valgrind complaint go away for me.
Attachment #505690 - Flags: review?(Olli.Pettay) → review+
Attachment #505690 - Flags: approval2.0? → approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.