Closed Bug 627309 Opened 10 years ago Closed 10 years ago
Forward button wrongly clipped in RTL mode when using lightweight themes
No description provided.
Comment on attachment 505381 [details] [diff] [review] v1 missed icons+text mode
Summary: Forward button wrongly clipped when using lightweight themes → Forward button wrongly clipped in RTL mode when using lightweight themes
blocking2.0: ? → final+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11
Could you please post some short description of what the problem was here for mere mortals like me? :-) Thanks!
Sure. Bug 578422 added a mask to the forward button in lwtheme mode so that it doesn't extend under the (now transparent) round back button. However, this mask was assuming LTR orientation, so it was cutting out the circle shape on the wrong side in RTL mode (see attachment 50537 [details] [diff] [review]). Instead of creating another mask for the RTL case, I chose to flip the whole toolbarbutton using -moz-transform, so that the mask was flipped, too. The other changes in the patch were to unflip the untransformed button's shape and icon so that it doesn't get double-flipped. Sorry, usually I'm the one who gets annoyed when people post insufficient bug descriptions...
Thanks a lot for your explanation, Markus! I just want to keep an eye on what's happening in the RTL land because I'll soon start testing Persian builds... :-)
You need to log in before you can comment on or make changes to this bug.