627339 - Make the smart (unified) folders code more generic and allow for arbitrary lists of folder flags

Status: ASSIGNED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Jonathan Protzenko [:protz]]

So Thunderbird Conversations tweaks the saved search for the smart folder inbox so that it also searches the sent folder. The problem is, if there's only one account, the smart inbox is hidden.

https://github.com/protz/GMail-Conversation-View/issues#issue/203?

That's bad. https://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#996 is where we make that decision. sid0 suggested various solutions, the cleanest one being to change the code in Thunderbird.

Instead of working on a fixed set of folder flags (unified search for nsMsgFolderFlags.Inbox, then for nsMsgFolderFlags.Sent, etc. etc.), we would create a generic implementation and then have the smart folders mode be a specific case of that generic implementation. Thunderbird Conversations would then add its own folder tree mode that has a saved search for Inbox + Sent, another one for Drafts, another one for Templates, etc. etc.

The generic code would hide the smart folder if it searches only one folder. Since, in our case, it will search Inbox and Sent folders, the grand unified inbox will always show up, so this will solve our problem.

Comment 1

[Charles]

Am I correct that this sounds like it may be related to two bugs I recently opened?

Allow customization of choices in View > Folders (Unified Folders)
bug 1159713

Add my own custom 'Unified Folder' choices
bug 1159716