Closed
Bug 627360
Opened 13 years ago
Closed 13 years ago
get_object_fallback should be broken up
Categories
(support.mozilla.org :: Code Quality, task)
support.mozilla.org
Code Quality
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jsocol, Unassigned)
References
Details
I love our get_object_fallback function, but especially after bug 627359, it's going to have an awful lot of Document-specific stuff in it. I'd like to suggest breaking this up into two methods: get_object_fallback() that can be used on anything with a title and a locale, and get_document_fallback() that has all the extra, Document-specific stuff in it. We could probably even use get_object_fallback() within get_document_fallback() to avoid duplicating that part of the code. Thoughts? Yes? No? Lynchmob?
Comment 1•13 years ago
|
||
On paper, this sounds like a great idea!
Updated•13 years ago
|
Target Milestone: 2011Q1 → 2011Q2
Updated•13 years ago
|
Target Milestone: 2011Q2 → 2011Q3
Reporter | ||
Comment 2•13 years ago
|
||
Eh, this works as-is, and is well tested. We can reopen or refactor if that method changes again.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Target Milestone: 2011Q3 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•