get_object_fallback should be broken up

RESOLVED WONTFIX

Status

support.mozilla.org
Code Quality
RESOLVED WONTFIX
7 years ago
7 years ago

People

(Reporter: jsocol, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
I love our get_object_fallback function, but especially after bug 627359, it's going to have an awful lot of Document-specific stuff in it.

I'd like to suggest breaking this up into two methods: get_object_fallback() that can be used on anything with a title and a locale, and get_document_fallback() that has all the extra, Document-specific stuff in it.

We could probably even use get_object_fallback() within get_document_fallback() to avoid duplicating that part of the code.

Thoughts? Yes? No? Lynchmob?
On paper, this sounds like a great idea!
Target Milestone: 2011Q1 → 2011Q2
Target Milestone: 2011Q2 → 2011Q3
(Reporter)

Comment 2

7 years ago
Eh, this works as-is, and is well tested. We can reopen or refactor if that method changes again.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
Target Milestone: 2011Q3 → ---
You need to log in before you can comment on or make changes to this bug.