627378 - Remove tearDownModule is not defined error

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Aaron Train [:aaronmt]]

In consensus via e-mail thread it was determined that tearDown function declaration is deemed unnecessary should the test not require one. Thus, it makes sense to remove the error found in the Error Console. Example below.

Tested with 1.5.1

Error: teardownModule is not defined
Source File: resource://mozmill/modules/frame.js -> testThemeInstallUninstall/test2.js
Line: 95

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

In Mozmill 1.5.2 this would cause our test to fail, because we have a console listener attached.

Andrew, we should make sure to not call the teardownModule function if none exists.

Comment 2

[Andrew Halberstadt [:ahal]]

(In reply to comment #1)
> In Mozmill 1.5.2 this would cause our test to fail, because we have a console
> listener attached.
> 
> Andrew, we should make sure to not call the teardownModule function if none
> exists.

Yesterday we decided to remove the console listener completely (see bug 608139) due to the problem of printing out errors twice and went with Heather's method instead.  I don't think this is an immediate problem for 1.5.2.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ah, haven't known that. That sounds good then. Aaron, how do you start Mozmill to get this failure? Somehow I don't see it.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I think there is no need for mozmill-1.5.2 then.

Comment 5

[Aaron Train [:aaronmt]]

(In reply to comment #3)
> Ah, haven't known that. That sounds good then. Aaron, how do you start Mozmill
> to get this failure? Somehow I don't see it.

Run with --debug on a test without a tearDownModule and it should appear in Error Console -- tested on 1.5.1

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I cannot see this problem with Mzomill 1.5.1 and a function without a teardownModule function.

Comment 7

[Aaron Train [:aaronmt]]

mozmill-restart -t firefox/restartTests/ -b "../default/firefox" --debug

Console output,

TEST-START | /home/aaronmt/Mozilla/mozmill-tests/firefox/restartTests/testThemeInstallUninstall/test1.js | setupModule
WARNING | setupModule | (SKIP) Bug 569813: New add-ons manager not supported yet
TEST-START | /home/aaronmt/Mozilla/mozmill-tests/firefox/restartTests/testThemeInstallUninstall/test1.js | testInstallTheme
WARNING | testInstallTheme | (SKIP) setupModule failed.
TEST-START | /home/aaronmt/Mozilla/mozmill-tests/firefox/restartTests/testThemeInstallUninstall/test2.js | setupModule


In the console I get Error: teardownModule is not defined
Source File: resource://mozmill/modules/frame.js ->
testThemeInstallUninstall/test2.js
Line: 95

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's a failure in the test, when I have marked all add-ons manager tests as skipped. We should simply remove the skipped line for teardownModule. Are other tests also affected?

Comment 9

[Aaron Train [:aaronmt]]

(In reply to comment #8)
> That's a failure in the test, when I have marked all add-ons manager tests as
> skipped. We should simply remove the skipped line for teardownModule. Are other
> tests also affected?

Interesting. No, as far as I can see, no other tests are affected that do not have tear downs but are not skipped. The error was misleading.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/e6ce2dd0e5d6