If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

need to include strres lib in embedding dist

VERIFIED FIXED in mozilla0.8

Status

()

Core
Embedding: APIs
P3
normal
VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: Judson Valeski, Assigned: Judson Valeski)

Tracking

({embed})

Trunk
mozilla0.8
x86
Linux
embed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
Embedding clients need the ability to use nsIPref. Our nsIPref impl requires
runtime access to stringbundles as some prefs point to .properties files which
need to be localized.
(Assignee)

Updated

17 years ago
Keywords: embed
Target Milestone: --- → mozilla0.6
(Assignee)

Comment 1

17 years ago
Created attachment 20597 [details] [diff] [review]
addition of strres and prefs for fonts
(Assignee)

Comment 2

17 years ago
so. the attatched patches add strres and prefs files to the manifest files for
embedding harnesses. Fonts now look better in the embedding apps. However,
because this dist doesn't use chrome urls (should I add chrome support too?)
nsPref spews warnings all over the place when it tries to load the chrome urls
that the prefs files point to for localizable prefs.

Comment 3

17 years ago
maybe we need to move the localized prefs that pertain to embedding over to
resource:/ urls?
(Assignee)

Comment 4

17 years ago
what's the diff between the two? I don't know.
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.6 → mozilla0.8

Comment 5

17 years ago
Created attachment 21082 [details] [diff] [review]
patch to make string bundles observer on the memory pressure API
(Assignee)

Comment 6

17 years ago
alec's patch doesn't apply to this bug.

Comment 7

17 years ago
I think I attached this to the right bug, somewhere :)
(Assignee)

Comment 8

17 years ago
my patch gets font's working properly. changing summary from "need to include
strres lib in embedding dist". It unfortunately drags in strres (which is needed
by prefs to handle foo.properties string bundles which can be values in prefs).
We really need to factor prefs so only those pertinent to embedding are included
(http://bugzilla.mozilla.org/show_bug.cgi?id=62755).
Summary: need to include strres lib in embedding dist → Fonts are hosed in win/lin embed test harnesses
r=bryner on valeski's patch
Summary: Fonts are hosed in win/lin embed test harnesses → need to include strres lib in embedding dist

Comment 10

17 years ago
sr=alecf
(Assignee)

Comment 11

17 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 12

17 years ago
Updating QA Contact
QA Contact: jrgm → mdunn

Comment 13

17 years ago
Correction: Changing QA contact for the Embed API bugs to David Epstein.
QA Contact: mdunn → depstein

Comment 14

17 years ago
Jud, I noticed that in the basebrowser files, the res/strres.properties line is
commented out. Is this right? In your patch (attachment), it's listed as enabled
(though in your 1/4 comments, you say it's "unfortunate").

Here's what's in these files wrt what's in your patch:

basebrowser-unix:

res/unixcharset.properties
components/libstrres.so
defaults/pref/all.js
defaults/pref/initpref.js
defaults/pref/unix.js
components/liburiloader.so

basebrowser-windows:

res/wincharset.properties
components/strres.dll
defaults/pref/all.js
defaults/pref/initpref.js
defaults/pref/unix.js
components/urildr.dll
(Assignee)

Comment 15

17 years ago
i'm not sure where the .properties files lie. we do include the strres lib, 
which is definately required.

Comment 16

17 years ago
hmm. I did a search and found the strres.properties file in 2 locations:
1. mozilla\dist\WIN32_D.OBJ\bin\res
2. mozilla\intl\strres\tests
So even though it's commented out in the basebrowser files, it must be directed 
from some other rdf file.

The stress lib file is included in the basebrowser files. Verifying bug as 
fixed. 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.