627502 - Create editors full review page in Zamboni

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Kumar McMillan [:kumar]]

Data grid for full review (nominated) view like old page: https://addons.allizom.org/en-US/editors/queue/nominated

This bug is limited to:
- the table structure with tabs at the top
- pagination at 100 add-ons
- the queue counts in the tabs (also note bug 622169)
- the sortable columns

...but most of that was done in bug 622172

This bug does *not* include the search box - that
is bug 622171.

Comment 1

[Kumar McMillan [:kumar]]

Fixed in https://github.com/jbalogh/zamboni/commit/157f76d90d401b9e1f95291a98ee5a96c8985a3f

Comment 2

[Kumar McMillan [:kumar]]

looks like search extensions are missing somehow.  Compare:
https://addons.allizom.org/en-US/editors/queue/nominated
to
https://addons.allizom.org/z/en-US/editors/queue/nominated

Comment 3

[Kumar McMillan [:kumar]]

Per discussion with jorge, it seems that remora was showing any kind of nominated files (except beta addons).  This might indicate bugs in the nomination process so the zamboni pages preserve that for now.  See bug 629789 for details.

This page is close!  But it still doesn't quite match remora.

Comment 4

[Kumar McMillan [:kumar]]

Note: this first landed in master with: https://github.com/jbalogh/zamboni/commit/157f76d90d401b9e1f95291a98ee5a96c8985a3f

Comment 5

[Wil Clouser [:clouserw]]

This is on preview but needs some tweaking.  -> .9

Comment 6

[Kumar McMillan [:kumar]]

I think the count in remora is wrong or perhaps multi-platform files are doubled up somehow.  The only version that appears in remora but not zamboni on PAMO is FenixFox https://addons.allizom.org/en-US/editors/review/126110  The reason is because its translation is not marked in the default locale and this was most likely due to a data entry bug in remora since that addon was created 1/16.  I'm marking this as fixed so QA can have a go at it (hi Krupa!)