62757 - winEmbed crashes trying to build combo boxes

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Judson Valeski]

Using a dist of winEmbed (*NOT* dist/*/bin/winEmbed, rather the one built from 
mozilla/embedding/config and disted to dist/*/Embed ).

I crash w/ the following stack:
nsComboboxControlFrame::Reflow(nsComboboxControlFrame * const 0x00b0b0c4, 
nsIPresContext * 0x023c0ef0, nsHTMLReflowMetrics & {...}, const 
nsHTMLReflowState & {...}, unsigned int & 0x00000000) line 1173 + 28 bytes
nsLineLayout::ReflowFrame(nsIFrame * 0x00b0b0c4, nsIFrame * * 0x0012b0fc, 
unsigned int & 0x00000000, nsHTMLReflowMetrics * 0x00000000, int & 0x00000000) 
line 921
nsBlockFrame::ReflowInlineFrame(nsBlockReflowState & {...}, nsLineLayout & 
{...}, nsLineBox * 0x00b35454, nsIFrame * 0x00b0b0c4, unsigned char * 
0x0012a674) line 4363 + 29 bytes
nsBlockFrame::DoReflowInlineFrames(nsBlockReflowState & {...}, nsLineLayout & 
{...}, nsLineBox * 0x00b35454, int * 0x0012acf0, unsigned char * 0x0012ab38, int 
0x00000000, int 0x00000000) line 4247 + 28 bytes
nsBlockFrame::DoReflowInlineFramesAuto(nsBlockReflowState & {...}, nsLineBox * 
0x00b35454, int * 0x0012acf0, unsigned char * 0x0012ab38, int 0x00000000, int 
0x00000000) line 4181 + 42 bytes
nsBlockFrame::ReflowInlineFrames(nsBlockReflowState & {...}, nsLineBox * 
0x00b35454, int * 0x0012acf0, int 0x00000000, int 0x00000000) line 4126 + 32 
bytes
nsBlockFrame::ReflowLine(nsBlockReflowState & {...}, nsLineBox * 0x00b35454, int 
* 0x0012acf0, int 0x00000000) line 3260 + 29 bytes
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState & {...}) line 2949 + 27 bytes
nsBlockFrame::Reflow(nsBlockFrame * const 0x00b0b03c, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1740 + 15 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00b0b03c, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableCellFrame::Reflow(nsTableCellFrame * const 0x00b0afdc, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 808
nsContainerFrame::ReflowChild(nsIFrame * 0x00b0afdc, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000de3, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableRowFrame::ResizeReflow(nsTableRowFrame * const 0x00b0aa70, nsIPresContext 
* 0x023c0ef0, nsHTMLReflowMetrics & {...}, RowReflowState & {...}, unsigned int 
& 0x00000000, int 0x00000000) line 965 + 48 bytes
nsTableRowFrame::Reflow(nsTableRowFrame * const 0x00b0aa70, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1552 + 33 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00b0aa70, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableRowGroupFrame::ReflowMappedChildren(nsTableRowGroupFrame * const 
0x00b0aa2c, nsIPresContext * 0x023c0ef0, nsHTMLReflowMetrics & {...}, 
RowGroupReflowState & {...}, unsigned int & 0x00000000, nsTableRowFrame * 
0x00000000, nsReflowReason eReflowReason_Resize, int 0x00000001, int 0x00000000) 
line 422 + 45 bytes
nsTableRowGroupFrame::Reflow(nsTableRowGroupFrame * const 0x00b0aa2c, 
nsIPresContext * 0x023c0ef0, nsHTMLReflowMetrics & {...}, const 
nsHTMLReflowState & {...}, unsigned int & 0x00000000) line 1091 + 38 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00b0aa2c, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableFrame::ReflowMappedChildren(nsTableFrame * const 0x00b0a95c, 
nsIPresContext * 0x023c0ef0, nsHTMLReflowMetrics & {...}, InnerTableReflowState 
& {...}, unsigned int & 0x00000000) line 3137 + 47 bytes
nsTableFrame::ResizeReflowPass2(nsTableFrame * const 0x00b0a95c, nsIPresContext 
* 0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 2082 + 31 bytes
nsTableFrame::Reflow(nsTableFrame * const 0x00b0a95c, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1717 + 34 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00b0a95c, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000003, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableOuterFrame::OuterReflowChild(nsTableOuterFrame * const 0x00b0a908, 
nsIPresContext * 0x023c0ef0, nsIFrame * 0x00b0a95c, const nsHTMLReflowState & 
{...}, nsHTMLReflowMetrics & {...}, int * 0x00000000, nsSize & {...}, nsMargin & 
{...}, nsMargin & {...}, nsMargin & {...}, nsReflowReason eReflowReason_Resize, 
unsigned int & 0x00000000) line 900 + 47 bytes
nsTableOuterFrame::Reflow(nsTableOuterFrame * const 0x00b0a908, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1440 + 69 bytes
nsBlockReflowContext::DoReflowBlock(nsHTMLReflowState & {...}, nsReflowReason 
eReflowReason_Resize, nsIFrame * 0x00b0a908, const nsRect & {...}, int 
0x00000001, int 0x00000000, int 0x00000001, nsMargin & {...}, unsigned int & 
0x00000000) line 562 + 36 bytes
nsBlockReflowContext::ReflowBlock(nsIFrame * 0x00b0a908, const nsRect & {...}, 
int 0x00000001, int 0x00000000, int 0x00000001, nsMargin & {...}, unsigned int & 
0x00000000) line 332 + 50 bytes
nsBlockFrame::ReflowBlockFrame(nsBlockReflowState & {...}, nsLineBox * 
0x00b0dc00, int * 0x0012c784) line 3879 + 56 bytes
nsBlockFrame::ReflowLine(nsBlockReflowState & {...}, nsLineBox * 0x00b0dc00, int 
* 0x0012c784, int 0x00000000) line 3142 + 23 bytes
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState & {...}) line 2949 + 27 bytes
nsBlockFrame::Reflow(nsBlockFrame * const 0x00b0a8bc, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1740 + 15 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00b0a8bc, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableCellFrame::Reflow(nsTableCellFrame * const 0x00b0a85c, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 808
nsContainerFrame::ReflowChild(nsIFrame * 0x00b0a85c, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000ed3, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableRowFrame::ResizeReflow(nsTableRowFrame * const 0x00b0a508, nsIPresContext 
* 0x023c0ef0, nsHTMLReflowMetrics & {...}, RowReflowState & {...}, unsigned int 
& 0x00000000, int 0x00000000) line 965 + 48 bytes
nsTableRowFrame::Reflow(nsTableRowFrame * const 0x00b0a508, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1552 + 33 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00b0a508, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000186, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableRowGroupFrame::ReflowMappedChildren(nsTableRowGroupFrame * const 
0x00b09730, nsIPresContext * 0x023c0ef0, nsHTMLReflowMetrics & {...}, 
RowGroupReflowState & {...}, unsigned int & 0x00000000, nsTableRowFrame * 
0x00000000, nsReflowReason eReflowReason_Resize, int 0x00000001, int 0x00000000) 
line 422 + 45 bytes
nsTableRowGroupFrame::Reflow(nsTableRowGroupFrame * const 0x00b09730, 
nsIPresContext * 0x023c0ef0, nsHTMLReflowMetrics & {...}, const 
nsHTMLReflowState & {...}, unsigned int & 0x00000000) line 1091 + 38 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00b09730, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableFrame::ReflowMappedChildren(nsTableFrame * const 0x00b096c8, 
nsIPresContext * 0x023c0ef0, nsHTMLReflowMetrics & {...}, InnerTableReflowState 
& {...}, unsigned int & 0x00000000) line 3137 + 47 bytes
nsTableFrame::ResizeReflowPass2(nsTableFrame * const 0x00b096c8, nsIPresContext 
* 0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 2082 + 31 bytes
nsTableFrame::Reflow(nsTableFrame * const 0x00b096c8, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1717 + 34 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00b096c8, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000003, unsigned int & 0x00000000) 
line 693 + 31 bytes
nsTableOuterFrame::OuterReflowChild(nsTableOuterFrame * const 0x00b09674, 
nsIPresContext * 0x023c0ef0, nsIFrame * 0x00b096c8, const nsHTMLReflowState & 
{...}, nsHTMLReflowMetrics & {...}, int * 0x00000000, nsSize & {...}, nsMargin & 
{...}, nsMargin & {...}, nsMargin & {...}, nsReflowReason eReflowReason_Initial, 
unsigned int & 0x00000000) line 900 + 47 bytes
nsTableOuterFrame::Reflow(nsTableOuterFrame * const 0x00b09674, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1440 + 69 bytes
nsBlockReflowContext::DoReflowBlock(nsHTMLReflowState & {...}, nsReflowReason 
eReflowReason_Initial, nsIFrame * 0x00b09674, const nsRect & {...}, int 
0x00000001, int 0x00000000, int 0x00000000, nsMargin & {...}, unsigned int & 
0x00000000) line 562 + 36 bytes
nsBlockReflowContext::ReflowBlock(nsIFrame * 0x00b09674, const nsRect & {...}, 
int 0x00000001, int 0x00000000, int 0x00000000, nsMargin & {...}, unsigned int & 
0x00000000) line 332 + 50 bytes
nsBlockFrame::ReflowBlockFrame(nsBlockReflowState & {...}, nsLineBox * 
0x00b229d0, int * 0x0012e218) line 3879 + 56 bytes
nsBlockFrame::ReflowLine(nsBlockReflowState & {...}, nsLineBox * 0x00b229d0, int 
* 0x0012e218, int 0x00000001) line 3142 + 23 bytes
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState & {...}) line 2949 + 27 bytes
nsBlockFrame::Reflow(nsBlockFrame * const 0x00aa0080, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1740 + 15 bytes
nsBlockReflowContext::DoReflowBlock(nsHTMLReflowState & {...}, nsReflowReason 
eReflowReason_Dirty, nsIFrame * 0x00aa0080, const nsRect & {...}, int 
0x00000001, int 0x00000000, int 0x00000001, nsMargin & {...}, unsigned int & 
0x00000000) line 562 + 36 bytes
nsBlockReflowContext::ReflowBlock(nsIFrame * 0x00aa0080, const nsRect & {...}, 
int 0x00000001, int 0x00000000, int 0x00000001, nsMargin & {...}, unsigned int & 
0x00000000) line 332 + 50 bytes
nsBlockFrame::ReflowBlockFrame(nsBlockReflowState & {...}, nsLineBox * 
0x00aa00f4, int * 0x0012ed50) line 3879 + 56 bytes
nsBlockFrame::ReflowLine(nsBlockReflowState & {...}, nsLineBox * 0x00aa00f4, int 
* 0x0012ed50, int 0x00000001) line 3142 + 23 bytes
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState & {...}) line 2949 + 27 bytes
nsBlockFrame::Reflow(nsBlockFrame * const 0x00a9fff8, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 1740 + 15 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00a9fff8, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
CanvasFrame::Reflow(CanvasFrame * const 0x00a9fccc, nsIPresContext * 0x023c0ef0, 
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 
0x00000000) line 306
nsBoxToBlockAdaptor::Reflow(nsBoxLayoutState & {...}, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000, int 0x00000000, int 0x00000000, int 0x00002328, int 
0x00001068, int 0x00000001) line 868
nsBoxToBlockAdaptor::DoLayout(nsBoxToBlockAdaptor * const 0x00a9ff8c, 
nsBoxLayoutState & {...}) line 525 + 52 bytes
nsBox::Layout(nsBox * const 0x00a9ff8c, nsBoxLayoutState & {...}) line 1002
nsScrollBoxFrame::DoLayout(nsScrollBoxFrame * const 0x00a9fde4, nsBoxLayoutState 
& {...}) line 379
nsBox::Layout(nsBox * const 0x00a9fde4, nsBoxLayoutState & {...}) line 1002
nsContainerBox::LayoutChildAt(nsBoxLayoutState & {...}, nsIBox * 0x00a9fde4, 
const nsRect & {...}) line 593 + 16 bytes
nsGfxScrollFrameInner::LayoutBox(nsBoxLayoutState & {...}, nsIBox * 0x00a9fde4, 
const nsRect & {...}) line 1029 + 17 bytes
nsGfxScrollFrameInner::Layout(nsBoxLayoutState & {...}) line 1112
nsGfxScrollFrame::DoLayout(nsGfxScrollFrame * const 0x00a9fd3c, nsBoxLayoutState 
& {...}) line 1037 + 15 bytes
nsBox::Layout(nsBox * const 0x00a9fd3c, nsBoxLayoutState & {...}) line 1002
nsBoxFrame::Reflow(nsBoxFrame * const 0x00a9fd04, nsIPresContext * 0x023c0ef0, 
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 
0x00000000) line 789
nsGfxScrollFrame::Reflow(nsGfxScrollFrame * const 0x00a9fd04, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 741 + 25 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x00a9fd04, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 693 + 31 bytes
ViewportFrame::Reflow(ViewportFrame * const 0x00a9fc90, nsIPresContext * 
0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 546
nsHTMLReflowCommand::Dispatch(nsHTMLReflowCommand * const 0x0279e8e0, 
nsIPresContext * 0x023c0ef0, nsHTMLReflowMetrics & {...}, const nsSize & {...}, 
nsIRenderingContext & {...}) line 146
PresShell::ProcessReflowCommands(int 0x00000001) line 5106
ReflowEvent::HandleEvent() line 4989
HandlePLEvent(ReflowEvent * 0x0261e970) line 5003
PL_HandleEvent(PLEvent * 0x0261e970) line 576 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00491070) line 509 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x003d00f8, unsigned int 0x0000c0dd, unsigned int 
0x00000000, long 0x00491070) line 1054 + 9 bytes
USER32! 77e13eb0()
USER32! 77e1401a()
USER32! 77e192da()
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e87903()

This happens on other sites trying to build combo boxes.

Comment 1

[Jon Granrose]

adding to cc.  mozilla0.6 out the door, so changing target to 0.8

Comment 2

[rods (gone)]

I am not sure what exe I am suppose to be debugging with. I don't have an 
executable at "dist/*/Embed" in fact I don't have an "Embed" directory under my 
dist directory.

All I have is "dist/*/bin/winEmbed"

Comment 3

[Judson Valeski]

I guess you didn't see my posting to seamonkey-internal. goto the
mozilla/embedding/config dir and run gmake or nmake -f makefile.win, depending
on your OS. That creates the Embed dir next to your bin dir. Run the embed app
from there.

Comment 4

[rods (gone)]

Yes, your are right I didn't see that mail....

It appears hyatt didn't add forms.css to the embed makefiles. Also, 
HtmlForm.properties needs to be there also.

Plus, the path for the HtmlForm.properties is hard coded to:
#define form_properties 
"chrome://communicator/locale/layout/HtmlForm.properties"

So really we have two problem here:
1)Packaging issue 
  forms.css 
  HtmlForm.properties
2) Harded path to HtmlForm.properties

Comment 5

[Judson Valeski]

ouch. over to Hyatt.

So, this is opening a can of worms. After talking to Rod about what's going on,
we're running into problems w/ "chrome" (css, .properties files, gif files, etc)
not being where it needs to be.

I've always thought of chrome as _UI_ from an application standpoint, rather
than a form control standpoint. However, clearly the two are the same here. To
fix this we need to get the right "chrome" (forms.css for example) over into the
embed dist dir so it can used for scrollbars and comobo boxes. We obviously
don't want to do a complete dir copy as we'd be getting a ton of stuff we don't
need. Can/Should chrome be factored out into "app" level chrome, and html forms
+ scrollbar level chrome?

Comment 6

[rods (gone)]

When forms.css was broken out, it wasn't added to the build scripts for embed. 
Further, none of the chrome/xul/xbl files are being copied over to support the 
scrollbar for embedding. Which begs the question as to whether there is a 
"default" skin for chrome so the scrollbar gets the right stuff.

The arrow.gif also nees to be copied over to the res directory, it is needed by 
the combobox.

Then a bigger can of worms, is HtmlForm.properties file. In the makefile.win in 
the forms/src directory it has these three lines:

CHROME_DIR	= locales\en-US
CHROME_L10N_DIR	= communicator\locale\layout
CHROME_L10N	= .\HtmlForm.properties

Which then creates the necessary directory structure over in the dist/win../bin 
area. Somehow we need to update/improve the embed build script to either copy 
this additional chrome info or something. 

The crash in the combobox code at the moment is really strange, a pointer inside 
the combobox object is getting whacked or something. I can bring up a page with 
a single combobox on it. I say don't worry about the scrash until we get all 
the chrome and properties file issues out of the way.

Comment 7

[Jon Granrose]

This sounds like a fairly involved bug that we have an idea how to fix, so I'm
lowering the priority to critical to get it off the blockers list.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Ow. It seems very very wrong that there is a dependency on the communicator
chrome package for layout's form control strings. Hyatt, Pink and I are in the
process of shifting various required resources into layout/.

Comment 9

[Judson Valeski]

*** Bug 62674 has been marked as a duplicate of this bug. ***

Comment 10

[Judson Valeski]

*** Bug 62137 has been marked as a duplicate of this bug. ***

Comment 11

[Tracy Walker [:tracy]]

also seeing this on linux embed

Comment 12

[David Hyatt]

fixed the scrollbars, the key navigation in the browser window, and the forms crash.

open issues that should have separate bugs filed:
  all.js is missing
  gif for down arrow on combo box is missing
  bindings files for inputs/textareas are missing
  properties file in the locale is missing and should be in global, not communicator

Separate bugs should be filed for these issues.

Comment 13

[Tracy Walker [:tracy]]

verified fixed on embed builds: 

Windows comm. 2000-12-21 embed-win32.zip
Linux comm. 2000-12-21 embed-i686-pc-linux-gnu.tar.gz 

Comment 14

[Judson Valeski]

this bug has nothing to do w/ scrollbars
(http://bugzilla.mozilla.org/show_bug.cgi?id=62762 does). And it's still showing
up as a blocker, is it fixed or not? I don't see any patches here, what was the
fix and who reviewed it? re-opening just to get some answers.

Comment 15

[Doug Turner (:dougt)]

I review/approved david's changes.  There were mostly to the packaging list and 
he also had some changes to the chrome registry.   

David checked these changes in on Dec 20 16:08.  Here is the link:

http://bonsai.mozilla.org/cvsquery.cgi?module=SeaMonkeyAll&branch=HEAD&cvsroot=/
cvsroot&date=explicit&mindate=977357160&maxdate=977357340&who=hyatt%25netscape.c
om

Comment 16

[Judson Valeski]

gracias.

Comment 17

[Brendan Eich [:brendan]]

We should talk briefly about why these changes ought not require super-review.
If they're truly exceptions, they or their class of source files ought to be
listed in http://www.mozilla.org/hacking/reviewers.html.

/be

Comment 18

[lchiang]

Jud - do we still have a winEmbed since we now use mfcEmbed?

Comment 19

[John Morrison]

There is still a winEmbed, built from the embedding/config directory, installed 
into dist\win32_(d|o).obj\Embed. It runs correctly, and the cvs changes dougt 
noted above are still in place. Marking verified.

(Although, is there a bug for the missing triangle on the select control?)

Comment 20

[Doug Turner (:dougt)]

Although I am not certian it is part of the embedding deliever, I hope that
winEmbed does not die off.  It is a good test example for those of us who know
win32 APIs and hate mfc.