627572 - Use class, not attribute selector, to write RTL-specific CSS

Status: VERIFIED FIXED

(Input :: General, enhancement, P3)

Description

[Fred Wenzel [:wenzel]]

Currently we use:

[dir=rtl] #something .somewhere {}

for CSS that pertains to RTL languages only. Attribute selectors are slow, Potch says.

Should apply a class like "dir-rtl" to the html tag instead.

Comment 1

[Fred Wenzel [:wenzel]]

Added the class "html-rtl" (and html-ltr, of course) to the body tag.

http://github.com/fwenzel/reporter/commit/cd5c851

QA: Should be sufficient to check that the dashboard and release pages look the same in Arabic on prod and stage. If you do find ugliness that's present on both, feel free to file a bug, (though fixing RTL is not the scope of this bug).

Comment 2

[Matt Brandt [:mbrandt]]

QA verified. Looks good.