627582 - Copying "Mobile Bookmarks" folder creates a copy named "mobile"

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Richard Newman [:rnewman]]

Sync creates a Mobile Bookmarks folder in the top level:

  // Use the (one) mobile root if it already exists
  let anno = "mobile/bookmarksRoot";
  let root = Svc.Annos.getItemsWithAnnotation(anno, {});
  if (root.length != 0)
    return root[0];

  // Create the special mobile folder to store mobile bookmarks
  let mobile = Svc.Bookmark.createFolder(Svc.Bookmark.placesRoot, "mobile", -1);
  Utils.anno(mobile, anno, 1);

When copied (!) by dragging it into a different folder in Show All Bookmarks, the copied folder is named "mobile", rather than picking up the localized name for the folder.

The expected behavior would be either:

* Forbid copying this folder; or
* Carry its localized name into the copy.

This does not occur when dragging Bookmarks Toolbar or Unsorted Bookmarks.

sdwilsh's summary was "don't do that!" (re copying mobile), so I thought I'd file :)

Satisfactory resolution would also be a different invocation of createFolder that causes the correct behavior.

Tested in 2011-01-17 build of Minefield.

Comment 1

[krishna kumar]

can we use this in any mobile which has that compatibility of accessing internet

Comment 2

[Philipp von Weitershausen [:philikon]]

(In reply to comment #1)
> can we use this in any mobile which has that compatibility of accessing
> internet

I don't understand your comment. Please clarify. Also, please don't randomly change flags without consulting with people who know what they mean first.

Comment 3

[Mark Banner (:standard8)]

Linking to bug 1432614, as I'm either going to need to solve this there or ensure it isn't a problem for the other folders.

Comment 4

[Mark Banner (:standard8)]

With bug 1432614 landing, and now bug 1442597 as a minor bug fix on its way to landing, this is now fixed!