fix tab focusing after closing a group in panorama

VERIFIED FIXED in Firefox 4.0b11

Status

defect
P3
normal
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: eyaler, Assigned: mitcho)

Tracking

({ux-consistency})

Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ux][polish][good first bug][watch out for patch interaction with 624939])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
str:

have two groups open in panorama.

current:
1. if you close the second group, focus goes to the nearest tab in the first group
2. if instead you close the last tab in the second group (via panorama or not), focus goes nowhere 

expected:
1. focus should behave consistently
2. perhaps focus should go to last used tab in last used group
I confirm this. There's no tab focus, nor group focus visible.
Keywords: ux-consistency
OS: Windows 7 → All
Hardware: x86 → All
Whiteboard: [ux][polish][good first bug]
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Priority: -- → P3
Posted patch Patch v1 (obsolete) — Splinter Review
Working patch. Test coming...
Attachment #506177 - Flags: feedback?(ian)
Posted patch Patch v1 with test (obsolete) — Splinter Review
Pushing to try.
Attachment #506177 - Attachment is obsolete: true
Attachment #506180 - Flags: review?(ian)
Attachment #506177 - Flags: feedback?(ian)
Whiteboard: [ux][polish][good first bug] → [ux][polish][good first bug][watch out for patch interaction with 624939]
Passed try.
Comment on attachment 506180 [details] [diff] [review]
Patch v1 with test

Looks good
Attachment #506180 - Flags: review?(ian) → review+
Attachment #506180 - Flags: approval2.0?
Comment on attachment 506180 [details] [diff] [review]
Patch v1 with test

a=beltzner, heed the notice about bad patch interaction!
Attachment #506180 - Flags: approval2.0? → approval2.0+
Attachment #506180 - Attachment is obsolete: true
Keywords: checkin-needed

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/6253431ae03f
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11
verified with nightly build of minefield.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 10

8 years ago
focus now goes to the nearest tab in the nearest group, not to the last used tab in the last used group. is this what we want?
(Reporter)

Comment 11

8 years ago
this happens even if i have focus on a different group
(Reporter)

Comment 12

8 years ago
filed Bug 637840
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.