Closed Bug 627736 Opened 13 years ago Closed 13 years ago

fix tab focusing after closing a group in panorama

Categories

(Firefox Graveyard :: Panorama, defect, P3)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b11

People

(Reporter: eyalgruss, Assigned: mitcho)

References

Details

(Keywords: ux-consistency, Whiteboard: [ux][polish][good first bug][watch out for patch interaction with 624939])

Attachments

(1 file, 2 obsolete files)

Patch for checkin
7.51 KB, patch
Details | Diff | Splinter Review 
str:

have two groups open in panorama.

current:
1. if you close the second group, focus goes to the nearest tab in the first group
2. if instead you close the last tab in the second group (via panorama or not), focus goes nowhere 

expected:
1. focus should behave consistently
2. perhaps focus should go to last used tab in last used group
I confirm this. There's no tab focus, nor group focus visible.
Keywords: ux-consistency
OS: Windows 7 → All
Hardware: x86 → All
Whiteboard: [ux][polish][good first bug]
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Priority: -- → P3
Attached patch Patch v1 (obsolete) — — Splinter Review 
Working patch. Test coming...
Attachment #506177 - Flags: feedback?(ian)
Attached patch Patch v1 with test (obsolete) — — Splinter Review 
Pushing to try.
Attachment #506177 - Attachment is obsolete: true
Attachment #506180 - Flags: review?(ian)
Attachment #506177 - Flags: feedback?(ian)
Whiteboard: [ux][polish][good first bug] → [ux][polish][good first bug][watch out for patch interaction with 624939]
Passed try.
Comment on attachment 506180 [details] [diff] [review]
Patch v1 with test

Looks good
Attachment #506180 - Flags: review?(ian) → review+
Attachment #506180 - Flags: approval2.0?
Comment on attachment 506180 [details] [diff] [review]
Patch v1 with test

a=beltzner, heed the notice about bad patch interaction!
Attachment #506180 - Flags: approval2.0? → approval2.0+

        Attachment #506180 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/6253431ae03f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11

    
    

    
  
verified with nightly build of minefield.
Status: RESOLVED → VERIFIED

    
    

    
  
focus now goes to the nearest tab in the nearest group, not to the last used tab in the last used group. is this what we want?

    
    

    
  
this happens even if i have focus on a different group

    
    

    
  
filed Bug 637840
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: