Menu API fails on 1.9.1 if context menu is a popup and not a menupopup

VERIFIED FIXED

Status

Testing Graveyard
Mozmill
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Dependency tree / graph

Details

(Whiteboard: [mozmill-1.5.2+][mozmill-2.0+])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
With the Menu API implemented on bug 597330, we can now easily handle context menu entries. As what we have discovered on bug 626674, in some cases we fail. As my investigation has shown it's related to the complete move from 'popup' to 'menupopup' on newer branches but not on older ones. There are still some cases when 'popup' nodes are in use on 1.9.1. We have to extend the API to also allow 'popup' nodes. Patch upcoming.

Would be great to get this into Mozmill 1.5.2.
(Assignee)

Comment 1

7 years ago
Created attachment 505821 [details] [diff] [review]
Patch v1
Attachment #505821 - Flags: review?(fayearthur+bugs)
(Assignee)

Comment 2

7 years ago
Before we forget about this bug lets CC Clint. Would be great to have this in 1.5.2 so it will be fixed for Shiretoko builds.
(Assignee)

Updated

7 years ago
Depends on: 624682
Comment on attachment 505821 [details] [diff] [review]
Patch v1

looks fine. Separate commit for whitespace changes.
Attachment #505821 - Flags: review?(fayearthur+bugs) → review+
(Assignee)

Comment 4

7 years ago
(In reply to comment #3) 
> looks fine. Separate commit for whitespace changes.

I assume that means we got approval for 1.5.2. I will check-in the patch without the whitespace changes.
Whiteboard: [mozmill-1.5.2?] → [mozmill-1.5.2+]
(Assignee)

Comment 5

7 years ago
Created attachment 507068 [details] [diff] [review]
Patch v2 (for check-in)
Attachment #505821 - Attachment is obsolete: true
Attachment #507068 - Flags: review+
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Blocks: 624682
No longer depends on: 624682
Verified fixed with 1.5.2rcr using latest 1.9.1
Status: RESOLVED → VERIFIED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.