With the Menu API implemented on bug 597330, we can now easily handle context menu entries. As what we have discovered on bug 626674, in some cases we fail. As my investigation has shown it's related to the complete move from 'popup' to 'menupopup' on newer branches but not on older ones. There are still some cases when 'popup' nodes are in use on 1.9.1. We have to extend the API to also allow 'popup' nodes. Patch upcoming. Would be great to get this into Mozmill 1.5.2.
Created attachment 505821 [details] [diff] [review] Patch v1
Attachment #505821 - Flags: review?(fayearthur+bugs)
Before we forget about this bug lets CC Clint. Would be great to have this in 1.5.2 so it will be fixed for Shiretoko builds.
Comment on attachment 505821 [details] [diff] [review] Patch v1 looks fine. Separate commit for whitespace changes.
Attachment #505821 - Flags: review?(fayearthur+bugs) → review+
(In reply to comment #3) > looks fine. Separate commit for whitespace changes. I assume that means we got approval for 1.5.2. I will check-in the patch without the whitespace changes.
Whiteboard: [mozmill-1.5.2?] → [mozmill-1.5.2+]
Created attachment 507068 [details] [diff] [review] Patch v2 (for check-in)
Landed as: https://github.com/mozautomation/mozmill/commit/3133b6ba9b35d3639721f091cb09da0f85c65b68 (master) https://github.com/mozautomation/mozmill/commit/1c6f7dc1922ba7e611aede9dfd9017da202873ed (1.5.2)
Whiteboard: [mozmill-1.5.2+] → [mozmill-1.5.2+][mozmill-2.0+]
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Verified fixed with 1.5.2rcr using latest 1.9.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.