Open Bug 627777 Opened 13 years ago Updated 2 years ago

When inserting RSS Button at toolbar, the Reload/Stop buttons are affected in inconsistent ways

Categories

(Firefox :: Toolbars and Customization, defect)

x86
macOS
defect

Tracking

()

UNCONFIRMED

People

(Reporter: netoarmando, Unassigned)

Details

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9) Gecko/20100101 Firefox/4.0b9
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9) Gecko/20100101 Firefox/4.0b9

When we add new buttons to the bar, the reload/stop button is splitted into two separate buttons while the customize dialog is opened and then it may collapses back to a special button or not depending on how additional buttons are placed in the bar. For instance, it will not collapse if we place a button in between the stop and reload buttons. And if we put a button to the left of both reload and stop buttons they will not collapsed and the Stop button is removed.

Reproducible: Always

Steps to Reproduce:
1. Right click on toolbar, click Customize
2. Insert RSS button on middle of Reload and Stop buttons
3. Confirm to see the changes

Do the same putting RSS icon left or right Reload and Stop buttons
Actual Results:  
Bad/Undesirable placement of buttons 

Expected Results:  
Something better. Old style 'Star It' button look is desirable for extra buttons, such as RSS one.
Severity: minor → normal
This is the area of the code that checks the presence of the buttons and does the combined mode deal : 

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4662

BUt I don't know what to do here. I hear you, when you say you want the RSS button in the combined area, but maybe that is something else. The thing is that the old customize thing may not apply 100% to the current state of UI changes in Firefox. Perhaps you could land an extension to try out your ideas.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.