627806 - Unimplemented CERT_DecodeCertificate should be removed from cert.h

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Elio Maldonado]

Attachment: Remove non-existent CERT_DecodeCertificate

CERT_DecodeCertificate is declared in cert.h. A search in MXR
http://mxr.mozilla.org/security/source/security/nss/lib/certdb/cert.h#528
it can't be found. I can't find it the source tree either
$grep -r CERT_DecodeCertificate mozilla/security/
mozilla/security/nss/lib/nss/nss.def:CERT_DecodeCertificatePoliciesExtension;
mozilla/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_cert.c:        PKIX_CERT_DEBUG("\t\tCERT_DecodeCertificatePoliciesExtension).\n");
mozilla/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_cert.c:        certPol = CERT_DecodeCertificatePoliciesExtension
mozilla/security/nss/lib/libpkix/include/pkix_errorstrings.h:PKIX_ERRORENTRY(CERTDECODECERTIFICATEPOLICIESEXTENSIONFAILED,CERT_DecodeCertificatePoliciesExtension failed,0),
mozilla/security/nss/lib/certdb/polcyxtn.c:CERT_DecodeCertificatePoliciesExtension(SECItem *extnValue)
mozilla/security/nss/lib/certdb/polcyxtn.c:    policies = CERT_DecodeCertificatePoliciesExtension(&policyItem);
mozilla/security/nss/lib/certdb/cert.h:CERT_DecodeCertificatePoliciesExtension(SECItem *extnValue);

The declaration should be removed or we should implement it.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 505871 [details] [diff] [review]
Remove non-existent CERT_DecodeCertificate

Agreed.

Comment 2

[Wan-Teh Chang]

Fixed on NSS trunk (NSS 3.13) by Elio.

cert.h,v 1.83 2011/01/29 16:49:31 emaldona%redhat.com