627824 - DirectWrite causes some text in menus to be cut off

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Rain [:rain1] (inactive)]

I'm pretty sure this is a recent regression. The text in the URL should be "Restart with Addons Disabled", I'm guessing.

Comment 1

[Rain [:rain1] (inactive)]

This doesn't happen without DWrite enabled. It also happens in Thunderbird, where the "Troubleshooting Information" in the Help menu is cut off to "Troubleshooting Informati...".

Comment 2

[Joe Drew (not getting mail)]

Text metrics are different with DirectWrite - the frontend just needs to be adjusted for that.

Comment 3

[Rain [:rain1] (inactive)]

Isn't the menu width automatically computed based on the text metrics?

Comment 4

[Joe Drew (not getting mail)]

I don't know, but Neil might!

Comment 5

[Neil Deakin]

(In reply to comment #3)
> Isn't the menu width automatically computed based on the text metrics?

Yes, indirectly, but to a maximum width of 42em as specified in menu.css

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Axel: I bet this will have l10n impact.

Dao: can you look at this? I'm hoping there's an easy fix, as it's late in the game.

Joe: can you make a mental note to give the front end team a heads up when doing things that will affect CSS layout ... or rendering of the UI in general?

Comment 7

[Rain [:rain1] (inactive)]

This regressed between 2011-01-17 and 2011-01-18: the regression range is <https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=66addc5c30ca&tochange=eb105fe0e41c>.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

--> Core::Layout as per JOEDREW!

Comment 10

[Raul Nicolae Malea]

Attachment: missing space after text

Comment 11

[Raul Nicolae Malea]

In my example missing space after text "Cauta in toate suplimentele" in search box in addons manager.

Comment 12

[Axel Hecht [:Pike]]

I recall that margaret fixed a menu cut-off bug, too, but I can't find it just now.

Comment 13

[Rain [:rain1] (inactive)]

Backing out part 1 of bug 562138 fixes this.

Comment 14

[:Margaret Leibovic]

(In reply to comment #12)
> I recall that margaret fixed a menu cut-off bug, too, but I can't find it just
> now.

Bug 585253, but that should only affect bookmark/history menuitems.

Comment 18

[Markus Stange [:mstange]]

Fixed by backout of bug 562138.

Comment 21

[Raul Nicolae Malea]

Attachment: final letters missing

Mozilla/5.0 (Windows NT 6.1; rv:2.0b11pre) Gecko/20110129 Firefox/4.0b11pre ID:20110129030338
Translate is correct.

Comment 22

[Raul Nicolae Malea]

This bug is NOT resolved. In two situation final letters is cut in my Minefield (romanian localized). If sentences are greater more final letter missing (cut off). Please see in attachments.
Mozilla/5.0 (Windows NT 6.1; rv:2.0b11pre) Gecko/20110129 Firefox/4.0b11pre ID:20110129030338

Comment 23

[Markus Stange [:mstange]]

That's not this bug, this bug is about menus. Please file a new bug.

Comment 24

[u60234]

Hi Raul. The problem you are seeing is not this bug. http://mxr.mozilla.org/l10n-central/source/ro/security/manager/chrome/pipnss/pipnss.properties#62 states that the string must fit in a 32 byte buffer, the ro string is currently 33 byte.

Comment 25

[Raul Nicolae Malea]

(In reply to comment #24)
> Hi Raul. The problem you are seeing is not this bug.
> http://mxr.mozilla.org/l10n-central/source/ro/security/manager/chrome/pipnss/pipnss.properties#62
> states that the string must fit in a 32 byte buffer, the ro string is currently
> 33 byte.

And what is resolved procedure?

Comment 26

[[not reading bugmail]]

see comment 23, your bug is different and this bug is resolved.

Comment 27

[Steve Scott (pxbugz)]

Verified fixed inMozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre