627859 - Use the standard placeholder-making function when re-scoping variable references in generator 'yield' expressions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

CompExprTransplanter::transplant does a bunch of bespoke pointer-fiddling
to take the free variable references in the 'yield' expression and re-scope
them within the comprehension tail clauses.

Bug 576847 corrected the way this code incorrectly constructed placeholders for function references, but it would also work to simply use the same placeholder construction function everybody else does.

Comment 1

[Jim Blandy :jimb]

Attachment: Use the standard placeholder-making function when re-scoping variable references in generator 'yield' expressions. [feedback=brendan in bug 576847]

CompExprTransplanter::transplant did a bunch of bespoke pointer-fiddling to
take the free variable references in the 'yield' expression and re-scope
them within the comprehension tail clauses. That code incorrectly
constructed placeholders for function references; this was fixed in bug 576847.

However, it would also work to simply use the same placeholder construction
function everybody else does. This patch makes it so.

Comment 2

[Jim Blandy :jimb]

Attachment: Use the standard placeholder-making function when re-scoping variable references in generator 'yield' expressions.

Refreshed and re-tested for current TM.

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 519746 [details] [diff] [review]
Use the standard placeholder-making function when re-scoping variable references in generator 'yield' expressions.

Sorry, thought I r+'ed this already a while ago.

/be

Comment 4

[Jim Blandy :jimb]

http://hg.mozilla.org/tracemonkey/rev/756abc094eb1

Adapted to latest sources.

Also, the original patch failed to correctly flatten the nested 'if's, and would move placeholders from outside the comprehension into the comprehension's lexdeps table. Added a test to catch this case, and fixed the problem.

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/756abc094eb1