bad file path in toolkit/themes/gnomestripe/mozapps/jar.mn

RESOLVED FIXED in mozilla2.0b11

Status

()

Toolkit
Themes
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: pascalc, Assigned: pascalc)

Tracking

unspecified
mozilla2.0b11
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 505964 [details] [diff] [review]
patch for the typo

There is a typo in toolkit/themes/gnomestripe/mozapps/jar.mn that probably prevents applications to load this ressource:

kin/classic/mozapps/extensions/stripes-info-negative.png

should be:

skin/classic/mozapps/extensions/stripes-info-negative.png

attaching a patch (asking review to Dave Townsend since he seems to be one of the two people editing this file on a regular basis, feel free to reassign)
Attachment #505964 - Flags: review?
Attachment #505964 - Flags: review? → review?(dtownsend)
Attachment #505964 - Flags: review?(dtownsend) → review+
Comment on attachment 505964 [details] [diff] [review]
patch for the typo

You just deleted the line? Why not replace it with the correct one?
Attachment #505964 - Flags: review+ → review-
(Assignee)

Comment 2

6 years ago
That's what I did:

-+ kin/classic/mozapps/extensions/stripes-info-negative.png (extensions/stripes-info-negative.png)
++ skin/classic/mozapps/extensions/stripes-info-negative.png (extensions/stripes-info-negative.png)
(Assignee)

Comment 3

6 years ago
it looks like there is a bug in the way bugzilla displays patches, I guess it is confused by the fact that this manifest file has its lines starting with pluses, if you look at the raw source of the patch, you can see that the line is fixed, not deleted:

https://bug627881.bugzilla.mozilla.org/attachment.cgi?id=505964
(Assignee)

Comment 4

6 years ago
Comment on attachment 505964 [details] [diff] [review]
patch for the typo

see comment #3, re-requesting review. Thanks.
Attachment #505964 - Flags: review- → review?

Updated

6 years ago
Attachment #505964 - Flags: review? → review?(dtownsend)
Comment on attachment 505964 [details] [diff] [review]
patch for the typo

So it is, sorry about that.
Attachment #505964 - Flags: review?(dtownsend) → review+

Updated

6 years ago
Attachment #505964 - Flags: approval2.0?
Assignee: nobody → pascalc
Attachment #505964 - Flags: approval2.0? → approval2.0+

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/7864ae3b2a0e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
You need to log in before you can comment on or make changes to this bug.