627921 - Sometimes screenshots are blank

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

Notice the screenshots @ 

https://addons.mozilla.org/en-US/firefox/addon/blahblah-1/
https://addons.allizom.org/en-US/firefox/addon/parijaatha-multiple-tab-han/

observed behavior:
Some of the screenshots for the two add-ons are blank.

example: https://addons-cdn.allizom.org/en-US/firefox/img/uploads/previews/full/52/52848.gif?modified=1295655059 is a 404

reproducible: sometimes

Also:
* All the screenshots were uploaded during add-on submission
* The screenshots show up in preview but turn up blank in detail pages and /edit pages

If I find a way to consistently reproduce this issue, I will add STR to this bug.

Comment 1

[Wil Clouser [:clouserw]]

The more details you can add to this the better.  Can you attach the images you tried?  Were they jpgs?  Anything abnormal about them?

Comment 2

[krupa raj[:krupa]]

Attachment: test image

This is one of images I tried uploading. I think this bug can be reproduced by clicking on "continue" when the image hasn't fully uploaded.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

I got this while trying to reproduce this: https://bugzilla.mozilla.org/show_bug.cgi?id=627303

Comment 4

[Jeff Balogh (:jbalogh)]

Jan 20 17:05:38 pm-gearman-amo02 [None] z.devhub.task:INFO [1@None] Resizing preview: /mnt/.../uploads/previews/thumbs/52/52881.png
Jan 20 17:05:38 pm-gearman-amo02 [None] z.devhub.task:ERROR Error saving preview: [Errno 2] No such file or directory: '/mnt/.../tmp/preview/792918c189c447e1b09d589a3a601774'

Comment 5

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> I think this bug can be reproduced by
> clicking on "continue" when the image hasn't fully uploaded.

The Save button is disabled

Comment 6

[Jeff Balogh (:jbalogh)]

(In reply to comment #5)
> The Save button is disabled

Ignore!

Comment 7

[krupa raj[:krupa]]

(In reply to comment #5)
> (In reply to comment #2)
> > I think this bug can be reproduced by
> > clicking on "continue" when the image hasn't fully uploaded.
> 
> The Save button is disabled

If you upload multiple screenshots, the continue button is enabled before the last screenshot is fully uploaded.

Comment 8

[Gregory Koberger (:gkoberger)]

Fixed! https://github.com/jbalogh/zamboni/commit/6dd0cbb8c9d3dbc1cc7e794b659d4d226a13026c

Comment 9

[krupa raj[:krupa]]

Now, the continue button is disabled while the screenshots are being uploaded.