Set fallback status immediately to prevent sending of wrong update type

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Right now we first retrieve the patchInfo property in the teardown module of test2.js. Because it internally checks for a valid update an exception gets thrown and we don't set the update type to fallback. We will have to move the update to the update's fallback property to setupModule to always make sure to have the correct update type selected.

Patch upcoming.
(Assignee)

Comment 1

7 years ago
Created attachment 506011 [details] [diff] [review]
Patch v1 [checked-in]
Attachment #506011 - Flags: review?(anthony.s.hughes)
Attachment #506011 - Flags: review?(anthony.s.hughes) → review+
(Assignee)

Comment 2

7 years ago
For an example how it looks like at the moment see the given URL.
(Assignee)

Comment 3

7 years ago
Created attachment 506016 [details] [diff] [review]
Backport (1.9.1) [checked in]

Anthony, can you please check-in once reviewed? Thanks.
Attachment #506016 - Flags: review?(anthony.s.hughes)
(Assignee)

Comment 4

7 years ago
Comment on attachment 506011 [details] [diff] [review]
Patch v1 [checked-in]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/ee8b95555fae (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/4ceca6f8801c (1.9.2)
Attachment #506011 - Attachment description: Patch v1 → Patch v1 [checked-in]
Attachment #506016 - Flags: review?(anthony.s.hughes) → review+
Comment on attachment 506016 [details] [diff] [review]
Backport (1.9.1) [checked in]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/a191dfd19b9d [mozilla1.9.1]
Attachment #506016 - Attachment description: Backport (1.9.1) → Backport (1.9.1) [checked in]
(Assignee)

Comment 6

7 years ago
Thanks Anthony. Closing as fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.