check strings in compartment checker, fix failures

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: [sg:critical?][hardblocker][fixed-in-tracemonkey])

Attachments

(3 attachments)

(Assignee)

Description

8 years ago
Created attachment 506046 [details] [diff] [review]
assert patch

The attached patch fails pretty hard on try server.  Gotta catch 'em all!
(Assignee)

Comment 1

8 years ago
IIUC, compartment mismatches are hardblockers.  I was wrong about 'fails pretty hard', though, there are two asserts on a whole try server run.
blocking2.0: --- → betaN+
Whiteboard: hardblocker
(Assignee)

Comment 2

8 years ago
Created attachment 506525 [details] [diff] [review]
fix assert 1

IRL r+
Attachment #506525 - Flags: review+
(Assignee)

Comment 3

8 years ago
Created attachment 506571 [details] [diff] [review]
move dtoaCache into the compartment

Let's see if it try's clean now.
Attachment #506571 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #506571 - Flags: review? → review?(wmccloskey)
(Assignee)

Comment 4

8 years ago
bugzilla dropped that the r+ in comment 2 was from Andreas.
Attachment #506571 - Flags: review?(wmccloskey) → review+
Whiteboard: [hardblocker][fixed-in-tracemonkey] → [sg:critical?][hardblocker][fixed-in-tracemonkey]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Group: core-security
You need to log in before you can comment on or make changes to this bug.