Closed Bug 627959 Opened 9 years ago Closed 9 years ago

check strings in compartment checker, fix failures

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: luke, Assigned: luke)

Details

(Whiteboard: [sg:critical?][hardblocker][fixed-in-tracemonkey])

Attachments

(3 files)

Attached patch assert patchSplinter Review
The attached patch fails pretty hard on try server.  Gotta catch 'em all!
IIUC, compartment mismatches are hardblockers.  I was wrong about 'fails pretty hard', though, there are two asserts on a whole try server run.
blocking2.0: --- → betaN+
Whiteboard: hardblocker
Attached patch fix assert 1Splinter Review
IRL r+
Attachment #506525 - Flags: review+
Let's see if it try's clean now.
Attachment #506571 - Flags: review?
Attachment #506571 - Flags: review? → review?(wmccloskey)
bugzilla dropped that the r+ in comment 2 was from Andreas.
Attachment #506571 - Flags: review?(wmccloskey) → review+
Whiteboard: [hardblocker][fixed-in-tracemonkey] → [sg:critical?][hardblocker][fixed-in-tracemonkey]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Group: core-security
You need to log in before you can comment on or make changes to this bug.