Created attachment 506046 [details] [diff] [review] assert patch The attached patch fails pretty hard on try server. Gotta catch 'em all!
IIUC, compartment mismatches are hardblockers. I was wrong about 'fails pretty hard', though, there are two asserts on a whole try server run.
blocking2.0: --- → betaN+
Created attachment 506525 [details] [diff] [review] fix assert 1 IRL r+
Attachment #506525 - Flags: review+
Created attachment 506571 [details] [diff] [review] move dtoaCache into the compartment Let's see if it try's clean now.
Attachment #506571 - Flags: review?
Attachment #506571 - Flags: review? → review?(wmccloskey)
bugzilla dropped that the r+ in comment 2 was from Andreas.
Attachment #506571 - Flags: review?(wmccloskey) → review+
http://hg.mozilla.org/tracemonkey/rev/f3e687a7fe94 http://hg.mozilla.org/tracemonkey/rev/8e7cf978049e http://hg.mozilla.org/tracemonkey/rev/5836983f910a
Whiteboard: hardblocker → [hardblocker][fixed-in-tracemonkey]
Whiteboard: [hardblocker][fixed-in-tracemonkey] → [sg:critical?][hardblocker][fixed-in-tracemonkey]
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/f3e687a7fe94 http://hg.mozilla.org/mozilla-central/rev/8e7cf978049e http://hg.mozilla.org/mozilla-central/rev/5836983f910a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.