Closed Bug 628183 Opened 9 years ago Closed 9 years ago

Remove charset menu into Web Developer when browser.menu.showCharacterEncoding is true

Categories

(Firefox :: Menus, defect)

All
Windows Vista
defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: m_kato, Unassigned)

References

Details

Attachments

(1 file)

By bug 596173, character encoding menu is added and L10N team can choose into top level or Web developer menu.

So when browser.menu.showCharacterEncoding is true, it can appear into top level.  But this config still keeps charset menu into Web developer too.

We should remove charset menu into Web Developer when browser.menu.showCharacterEncoding is true.
Comment on attachment 515007 [details] [diff] [review]
switch #appmenu_developer_charsetMenu

We should not show same two menu within the Firefox menu.

Adding Patrick to the CC list and requesting review for ABE's patch.
Attachment #515007 - Flags: ui-review?(faaborg)
Attachment #515007 - Flags: review?(gavin.sharp)
Comment on attachment 515007 [details] [diff] [review]
switch #appmenu_developer_charsetMenu

It's redundant, but some users will miss that it has been moved, and expect it to be in its old position.  For instance if you sit down at a computer that has been customized in this way, or you just started using this localized build of Firefox and you have muscle memory from another locale.  There isn't much cost to cluttering the Web developer menu, and there are some downsides to completely moving the command for only some locales.
Attachment #515007 - Flags: ui-review?(faaborg) → ui-review-
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Attachment #515007 - Flags: review?(gavin.sharp)
If it's the decision, I won't reopen this bug but let me share my idea:

In most case, users will not change the config via about:config, will not use multiple locale, will not read document for other locale.
Even when they use other locale's Firefox and the menu is not under the WebDev menu, they can easily and naturally find it since the menu will always shown just next to the WebDev menu.
# when they try to open the sub-menu, they naturally find it on the top level

What I worry most is, if there are two same menu in the Firefox Menu, users may think these two have different features and confuse about it.

You also say there isn't much cost to cluttering the WebDev menu but I believe that fewer (simpler) menu in single button is important point of Firefox Menu.

That's why I believe it's better to move the menu, not duplicate the menu.
You need to log in before you can comment on or make changes to this bug.