Closed Bug 628304 Opened 15 years ago Closed 12 years ago

Flash plugin crash alert on all tabs

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: aphadke, Unassigned)

Details

Minefield shows the "yellow" crash overlay on all open tabs when flash crashes. Pressing, "Reload Page" or "Submit a crash report" on one tab should technically make that specific option disappear on all tabs. users might end up sending multiple crash reports resulting in lot of false positives in crash-stats.
using submit report should cause submit report to disappear, but the converse is not true. if i reload one page but decide on another page that the crash matters, i should still be able to report it.
Component: General → Breakpad Integration
Product: Firefox → Toolkit
QA Contact: general → breakpad.integration
Version: unspecified → Trunk
based on my experience, if flash crashes on tab-1 it crashes on all open tabs (say tabs 1-6). Say I report the flash crash for tab-1, then go to tab-2 and report it again; won't the crash on tab-2 be false positive?
there's only one flash plugin, the flash plugin crashes, we don't know which of n tabs hosting flash is the one responsible for the crash. the user may have some inclination. if i have a tab which has an offscreen flash ad and a second tab w/ a youtube video and a third tab w/ a gmail file upload widget, i could easily choose to reload the gmail tab, ignore the ad tab and choose to submit from youtube because only on the youtube tab was the fact that it crashed something that would "make sense" as something i'd want to report.
would it make sense to send crash reports from all tabs when the flash happens? Does mdsw have the ability to distinguish between the crashed reports and non-crashed reports?
dolske, didn't you implement something that removed the "submit crash report" link on other tabs once it was submitted once?
Yes, the "submit crash report" should be removed from all instances of the plugin-crash message once a report is submitted for that crash. (It's per instance, so if you crash on YouTube, then open a new YouTube tab and crash again, they are separate instances). What doesn't get removed is the "a plugin on this page crashed, reload the page" infobar. That doesn't submit the report, and the bar should stick around until you actually reload the page (because whatever plugin instance was on the page is likely still broken)..
Note that we don't show the bar on every page, only pages which (1) have that plugin somewhere in the page and (2) the plugin's size is too small to show the normal in-content error overlay.
Summary: multiple flash plugin alerts → Flash plugin crash alert on all tabs
my plug-ins are not working and i've done everything i can to make my media play but it wont.
Anurag do you still see this?
Flags: needinfo?(aphadke)
wayne - thx for the ping. marking the bug as resolved as it's no longer happening for me.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(aphadke)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.