All users were logged out of Bugzilla on October 13th, 2018

"Reviews" heading needs better styling

VERIFIED FIXED in 5.12.10

Status

P4
normal
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: stephend, Assigned: cvan)

Tracking

unspecified
5.12.10

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
Created attachment 506577 [details]
Screenshot

The "Reviews" heading is supposed to look more like http://people.mozilla.com/~chowse/drop/amo/discovery/06_Addon_Reviews.png than the screenshot I've attached.
Assignee: nobody → cwiemeersch
Priority: -- → P4
Target Milestone: --- → Q1 2011
(Assignee)

Comment 1

8 years ago
The "Reviews" heading was adjusted to be consistent with the style of the EULA heading here: http://people.mozilla.com/~chowse/drop/amo/discovery/02_Addon_EULA.png

Shall I change the "Reviews" heading to match the original mockup?
Up to chowse, as far as I'm concerned.  This is a P4 and not in a close milestone so no hurry.
(In reply to comment #1)
> Shall I change the "Reviews" heading to match the original mockup?

No, you assumed correctly: the separator should be on the same baseline as the header. I neglected to update that mockup when I posted the next iteration of mockups: http://people.mozilla.com/~chowse/drop/amo/discovery/v2/
So we need to remove the background from this element.  Is there anything else that needs to happen in this bug?
Target Milestone: Q1 2011 → 5.12.9
Target Milestone: 5.12.9 → 5.12.10
(Assignee)

Comment 5

8 years ago
Committed: https://github.com/jbalogh/zamboni/commit/f82b6fa
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

8 years ago
Created attachment 510354 [details]
Post-fix screenshot
(Reporter)

Comment 7

8 years ago
Verified FIXED on https://addons.allizom.org/en-US/firefox/discovery/addon/apture-highlights/.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.