628448 - "Reviews" heading needs better styling

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P4)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

The "Reviews" heading is supposed to look more like http://people.mozilla.com/~chowse/drop/amo/discovery/06_Addon_Reviews.png than the screenshot I've attached.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

The "Reviews" heading was adjusted to be consistent with the style of the EULA heading here: http://people.mozilla.com/~chowse/drop/amo/discovery/02_Addon_EULA.png

Shall I change the "Reviews" heading to match the original mockup?

Comment 2

[Wil Clouser [:clouserw]]

Up to chowse, as far as I'm concerned.  This is a P4 and not in a close milestone so no hurry.

Comment 3

[Chris Howse [:chowse]]

(In reply to comment #1)
> Shall I change the "Reviews" heading to match the original mockup?

No, you assumed correctly: the separator should be on the same baseline as the header. I neglected to update that mockup when I posted the next iteration of mockups: http://people.mozilla.com/~chowse/drop/amo/discovery/v2/

Comment 4

[Wil Clouser [:clouserw]]

So we need to remove the background from this element.  Is there anything else that needs to happen in this bug?

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Committed: https://github.com/jbalogh/zamboni/commit/f82b6fa

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.allizom.org/en-US/firefox/discovery/addon/apture-highlights/.