Closed
Bug 628575
Opened 13 years ago
Closed 13 years ago
Two security-sensitive checkboxes have the same ID, causing <label> confusion
Categories
(bugzilla.mozilla.org :: General, defect)
bugzilla.mozilla.org
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: justdave)
References
Details
Attachments
(1 file)
908 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
On https://bugzilla.mozilla.org/enter_bug.cgi?product=mozilla.org If I click the label "Confidential Mozilla Project Bug (use another group if possible)", a different checkbox gets checked. This happens because there are two <label for="bit-6"> elements and two <input type="checkbox" id="bit-6"> elements. This might be a regression from bug 626265.
Assignee | ||
Comment 1•13 years ago
|
||
What do you want to bet that's why it wasn't clickable to begin with? heh. Well, on the plus side, that is the correct group bit, still. That happens to be the designated group for the security checkbox on that product. The name gets submitted not the id, so we could make the ID different on the special security box...
Assignee | ||
Comment 2•13 years ago
|
||
Assignee: nobody → justdave
Attachment #506656 -
Flags: review?(dkl)
Comment 3•13 years ago
|
||
Comment on attachment 506656 [details] [diff] [review] patch I should have caught that before. Patch looks good to me. r=dkl
Attachment #506656 -
Flags: review?(dkl) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Committing to: /Users/dave/Source/Bugzilla/bmo3.6/ modified template/en/default/bug/create/create.html.tmpl Committed revision 7238. Using saved push location: bzr+ssh://justdave%40mozilla.com@bzr.mozilla.org/bmo/3.6/ Pushed up to revision 7238. this will go live next time we update the main site (may happen later today)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Component: Bugzilla: Other b.m.o Issues → General
Product: mozilla.org → bugzilla.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•