628575 - Two security-sensitive checkboxes have the same ID, causing <label> confusion

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Jesse Ruderman]

On https://bugzilla.mozilla.org/enter_bug.cgi?product=mozilla.org

If I click the label "Confidential Mozilla Project Bug (use another group if possible)", a different checkbox gets checked.

This happens because there are two <label for="bit-6"> elements and two <input type="checkbox" id="bit-6"> elements.

This might be a regression from bug 626265.

Comment 1

[Dave Miller [:justdave]]

What do you want to bet that's why it wasn't clickable to begin with?  heh.

Well, on the plus side, that is the correct group bit, still.  That happens to be the designated group for the security checkbox on that product.

The name gets submitted not the id, so we could make the ID different on the special security box...

Comment 2

[Dave Miller [:justdave]]

Attachment: patch

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 506656 [details] [diff] [review]
patch

I should have caught that before. Patch looks good to me. r=dkl

Comment 4

[Dave Miller [:justdave]]

Committing to: /Users/dave/Source/Bugzilla/bmo3.6/
modified template/en/default/bug/create/create.html.tmpl
Committed revision 7238.
Using saved push location: bzr+ssh://[e-mail]/bmo/3.6/
Pushed up to revision 7238.

this will go live next time we update the main site (may happen later today)