62858 - OS/2 changes to Psm-glue extension

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[jhp (no longer active)]

For OS/2, the name of the psm daemon should be "psm.exe".  Also, we 
need to take the windows path in certain places, rather than the 
default.

Comment 1

[jhp (no longer active)]

Attachment: OS/2 patch for file in extensions/psm-glue/src

Comment 2

[Mike Kaply [:mkaply]]

This one is pretty straightforward - it only impact OS/2.

Since it is psm-glue (Mozilla tree) I'll take care of checking it in.

All I need is an r= and an sr=.

Thanks

Comment 3

[Christopher Blizzard (:blizzard)]

Adding nelson, wtc and cls who have to review + approve.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Since this patch is to PSM, not NSS, shouldn't it be reviewed by
Javi (PSM engineer) instead of me (NSS engineer)?

Comment 5

[Javier Delgadillo]

r=javi

Comment 6

[Wan-Teh Chang]

r=wtc.

Javi, does the PSM team own extensions/psm-glue/src?

Comment 7

[Javier Delgadillo]

we own it, but it's not locked down.

Comment 8

[Mike Kaply [:mkaply]]

Since there is no super reviewer for psm, can I take the wtc r= as an sr=?

Comment 9

[Wan-Teh Chang]

No, I am not a super reviewer and I am not familiar
with the checkin policy of the Mozilla browser client.

I just wanted to add that this patch (id=20699)
obviously does not affect any platform other than
OS/2 that no additional review is needed, IMO.

Comment 10

[Javier Delgadillo]

brendan has historically reviewed many psm related check-ins.  You may want to
try him.

Comment 11

[Brendan Eich [:brendan]]

sr=[e-mail], and I think such OS2-only changes are already covered by
exceptions (definitely the case for changes to OS2-only files, and by extension
also the case for additions to #if clauses).  I'm happy to take a look if
another level of review seems warranted when changing an XP file, of course.
Should I elaborate the #if-extension exception in the reviewers.html doc?

/be

Comment 12

[Mike Kaply [:mkaply]]

Fix checked in

Comment 13

[John Unruh]

Verified per [e-mail]'s comments

Comment 14

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 15

[John Unruh]

Mass changing Security:Crypto to PSM